Skip to content

Cellular: Refactored GEMALTO_CINTERION_Module to GEMALTO_CINTERION #8866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2018
Merged

Cellular: Refactored GEMALTO_CINTERION_Module to GEMALTO_CINTERION #8866

merged 1 commit into from
Dec 14, 2018

Conversation

AriParkkila
Copy link

Description

Gemalto Cinterion was only cellular driver to have a Module class. This change unifies implementation to other drivers by refactoring Module class implementation to device class.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@AriParkkila
Copy link
Author

@jarvte please review

@0xc0170 0xc0170 requested a review from a team November 26, 2018 10:31
@cmonr
Copy link
Contributor

cmonr commented Dec 12, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 12, 2018

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@cmonr
Copy link
Contributor

cmonr commented Dec 12, 2018

CI restarted for jenkins-ci/greentea-test

Failure: K82F iar_arm / K82F-IAR.tests-mbed_hal-qspi.qspi frequency setting test

@cmonr cmonr merged commit 8bd1d06 into ARMmbed:master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jarvte jarvte jarvte approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AriParkkila @cmonr @mbed-ci @0xc0170 @jarvte