Skip to content

Fix compilation warnings (apart from nanostack) #8855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2018
Merged

Fix compilation warnings (apart from nanostack) #8855

merged 1 commit into from
Dec 3, 2018
+5 −4

Conversation

michalpasztamobica
Copy link
Contributor

Description

Fixing the compilation warnings.
The fixes for warnings coming from nanostack will be requested in the https://github.com/ARMmbed/sal-stack-nanostack-private/ repository

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@michalpasztamobica
Copy link
Contributor Author

@SeppoTakalo , this is the same as this PR, minus the nanostack fixes. I will submit a PR to nanostack repo, as soon as I have privileges to push there.

I could not find this file: features/nanostack/mbed-mesh-api/source/wisun_tasklet.c in the nanostack repo, so I assumed it is our addition and applied a fix in this pull request - I hope this is right?

Please review.

@0xc0170 0xc0170 requested a review from SeppoTakalo November 24, 2018 18:53
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 26, 2018

components/802.15.4_RF/stm-s2lp-rf-driver/source/NanostackRfPhys2lp.cpp

Note, there are conflicts now

@michalpasztamobica
Copy link
Contributor Author

Thanks, @0xc0170. Conflicts are now fixed.

@cmonr cmonr removed the rollup PR label Dec 1, 2018
@cmonr
Copy link
Contributor

cmonr commented Dec 1, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 1, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

@0xc0170 0xc0170 merged commit bf36ff7 into ARMmbed:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michalpasztamobica @0xc0170 @cmonr @mbed-ci @SeppoTakalo