Skip to content

Bugfix restrict send size; namespace fixes; ATCmdParser::read return value fix #8841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 3, 2018
Merged

Bugfix restrict send size; namespace fixes; ATCmdParser::read return value fix #8841

merged 5 commits into from
Dec 3, 2018

Conversation

VeijoPesonen
Copy link
Contributor

Description

  • Drops std:: because string.h is included
  • Truncates data to be send to modem to 2048 bytes - AT command set restriction
  • Dropping duplicate "using namespace mbed;" - one already on the line 33
  • Fixes return value check when calling ATCmdParser::read()

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@VeijoPesonen
Copy link
Contributor Author

@ARMmbed/mbed-os-ipcore please review.

SeppoTakalo
SeppoTakalo reviewed Nov 22, 2018
View reviewed changes
components/wifi/esp8266-driver/ESP8266/ESP8266.cpp Outdated
@@ -550,6 +548,9 @@ bool ESP8266::dns_lookup(const char *name, char *ip)

nsapi_error_t ESP8266::send(int id, const void *data, uint32_t amount)
{
// +CIPSEND supports up to 2048 bytes at a time
amount = amount > 2048 ? 2048 : amount;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need check here if this is TCP or UDP.

For TCP this is fine.
For UDP this needs to return parameter error.

Copy link
Contributor Author

@VeijoPesonen VeijoPesonen Nov 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeppoTakalo issue fixed.

Truncates TCP stream and NACKs UDP datagram when sending too much data
fefef0d 
ESP8266 maximum packet size when sending is 2048 bytes.
@0xc0170 0xc0170 requested a review from a team November 23, 2018 10:57
@cmonr
Copy link
Contributor

cmonr commented Dec 1, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 1, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

@0xc0170 0xc0170 merged commit acbde4e into ARMmbed:master Dec 3, 2018
@VeijoPesonen VeijoPesonen deleted the bugfix-restrict_send_size2 branch January 14, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.0-rc3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@VeijoPesonen @cmonr @mbed-ci @0xc0170 @SeppoTakalo @adbridge