Fixed bugs in Fast Model MPS2 GCC startup scripts #8648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreenTea test results for gcc attached |
0xc0170
approved these changes
Nov 6, 2018
| @@ -70,7 +70,7 @@ __isr_vector: | |||
| .long UARTTX4_Handler /* UART 4 TX Handler */ | |||
| .long ADCSPI_Handler /* SHIELD ADC SPI exceptions Handler */ | |||
| .long SHIELDSPI_Handler /* SHIELD SPI exceptions Handler */ | |||
| .long PORT0_0_Handler /* GPIO Port 0 pin 0 Handler */ | |||
| .long PORT0_0_Handler /* GPIO Port 0 pin 0 Handler */ | |||
There was a problem hiding this comment.
Cosmetic/coding changes should be separate commit
There was a problem hiding this comment.
Fixed, pushed a separate commit
donatieng
approved these changes
Nov 8, 2018
0xc0170
approved these changes
Nov 8, 2018
Merged
|
Note: This PR is now a part of a rollup PR (#8686). No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged. If any more commits are made in this PR, this PR will remain open and have to go through CI on its own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Fast Models MPS2 targets (M3/M4/M7), the GCC startup scripts defined external interrupt handlers were wrong.
Now got them fixed. They are aligned with ARMCC and IAR toolchain startup scripts
Pull request type
@ARMmbed/mbed-os-hal