Feature qspi kinetis #8485

mmahadevan108 · 2018-10-19T15:42:56Z

Description

Adds QSPI support for KL82Z and K82F
Makes additions to the flash config files in the TESTS directory as the QSPI flash device used on these boards and not entirely compatible with the ones available inside mbed-os
QSPI support is only added for the Freedom boards. Other boards for these SoC's will have to make QSPI additions based on their hardware.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

This should support QSPI on Kinetis devices Signed-off-by: Mahesh Mahadevan <[email protected]>

This needs a device specific file Signed-off-by: Mahesh Mahadevan <[email protected]>

Signed-off-by: Mahesh Mahadevan <[email protected]>

Add 16-bit access mode when writing the transfer size to prevent the QSPI transaction from starting Signed-off-by: Mahesh Mahadevan <[email protected]>

Add the QSPI pin defines, clock information and flash details Signed-off-by: Mahesh Mahadevan <[email protected]>

1. Add flash config files. 2. Flash used is MX25U3235F, include information for this device in the flash config file Signed-off-by: Mahesh Mahadevan <[email protected]>

mmahadevan108 · 2018-10-19T15:43:13Z

cc @0xc0170 @maclobdell

mmahadevan108 · 2018-10-19T15:46:00Z

@cmonr

cmonr

A single implementation question. Looks wonderful!

cmonr · 2018-10-19T16:11:13Z

TESTS/mbed_hal/qspi/flash_configs/Freescale/K82F/flash_config.h

+#define QSPI_ERASE_BLOCK_32_MAX_TIME            1150000     // 1s
+#define QSPI_ERASE_BLOCK_64_MAX_TIME            2300000     // 2s
+
+#define EXTENDED_SPI_ENABLE()                                               \


Why is this in a preprocessor macro instead of being an inlined static function?

This is how the tests are written

Why is this in a preprocessor macro instead of being an inlined static function?

@maciejbocianski

@cmonr @mmahadevan108 @0xc0170
There was two reasons why preprocessor macro was used:

it can be easily redefined in target flash config to cover some target specifics TESTS/mbed_hal/qspi/flash_configs/STM/DISCO_L475VG_IOT01A/flash_config.h

it prevents cyclic dependency between flash config TESTS/mbed_hal/qspi/flash_configs/MX25RXX35F_config.h and test utils TESTS\mbed_hal\qspi\qspi_test_utils.h

cmonr · 2018-10-19T16:23:21Z

targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_K82F/drivers/fsl_qspi.c

@@ -12,10 +15,11 @@
 *   list of conditions and the following disclaimer in the documentation and/or
 *   other materials provided with the distribution.
 *
- * o Neither the name of Freescale Semiconductor, Inc. nor the names of its
+ * o Neither the name of the copyright holder nor the names of its


cmonr · 2018-10-19T16:28:44Z

targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_KL82Z/drivers/fsl_qspi.c

@@ -1,9 +1,12 @@
 /*
+ * The Clear BSD License


NirSonnenschein · 2018-10-21T09:50:18Z

/morph build

mbed-ci · 2018-10-21T12:40:37Z

Build : SUCCESS

Build number : 3421
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8485/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-21T14:18:31Z

Exporter Build : FAILURE

Build number : 3045
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8485/

mbed-ci · 2018-10-21T17:50:39Z

Test : SUCCESS

Build number : 3215
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8485/3215

NirSonnenschein · 2018-10-21T19:56:02Z

exporter build failed because if IAR license issues: retrying:
/morph export-build

mbed-ci · 2018-10-21T20:59:29Z

Exporter Build : SUCCESS

Build number : 3048
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8485/

cmonr · 2018-10-22T16:43:00Z

Anyone from @ARMmbed/mbed-os-hal available to review?

0xc0170 · 2018-10-23T08:21:22Z

Makes additions to the flash config files in the TESTS directory as the QSPI flash device used on these boards and not entirely compatible with the ones available inside mbed-os

Tests are all green, can you share the logs here (from your email I understood the config for this flash still needed to be done) ?

0xc0170

Waiting for the QSPI tests results

mmahadevan108 · 2018-10-23T13:13:23Z

@0xc0170 Below are the QSPI test results for K82F and KL82Z. The email regarding the flash config is for a third target (LPC564XX) that I working on, I will submit that a separate PR once the flash config file is ready.

K82F_QSPI.txt
KL82Z_QSPI.txt

QSPI test results provided. Please rereview.

cmonr · 2018-10-23T17:38:07Z

Bringing this in.

mmahadevan108 added 7 commits October 18, 2018 12:14

MCUXpresso: Add the QSPI HAL driver

e28fb74

This should support QSPI on Kinetis devices Signed-off-by: Mahesh Mahadevan <[email protected]>

QSPI: Remove QSPI from UBRIDGE and USENSE target

6b1bef2

This needs a device specific file Signed-off-by: Mahesh Mahadevan <[email protected]>

K82F, KL82Z: Update the QSPI SDK driver to the latest version

3bd6235

Signed-off-by: Mahesh Mahadevan <[email protected]>

K82F, KL82Z: Update register access mode for QSPI IPCR register

9f64e46

Add 16-bit access mode when writing the transfer size to prevent the QSPI transaction from starting Signed-off-by: Mahesh Mahadevan <[email protected]>

K82F FRDM: Update the K82F Freedom board for QSPI

858e536

Add the QSPI pin defines, clock information and flash details Signed-off-by: Mahesh Mahadevan <[email protected]>

KL82Z FRDM: Update the KL82Z Freedom board for QSPI

9dc3f8c

Add the QSPI pin defines, clock information and flash details Signed-off-by: Mahesh Mahadevan <[email protected]>

Update the QSPI unit test for Freescale boards

86ae041

1. Add flash config files. 2. Flash used is MX25U3235F, include information for this device in the flash config file Signed-off-by: Mahesh Mahadevan <[email protected]>

cmonr requested a review from a team October 19, 2018 16:10

cmonr added the needs: review label Oct 19, 2018

cmonr approved these changes Oct 19, 2018

View reviewed changes

cmonr requested a review from 0xc0170 October 19, 2018 16:33

cmonr added needs: CI release-version: 5.10.3 and removed needs: review labels Oct 19, 2018

cmonr added ready for merge needs: review and removed needs: CI ready for merge labels Oct 22, 2018

0xc0170 previously requested changes Oct 23, 2018

View reviewed changes

cmonr merged commit 0db8960 into ARMmbed:master Oct 23, 2018

mmahadevan108 deleted the feature-qspi-kinetis branch October 24, 2018 14:03

cmonr removed the needs: review label Oct 24, 2018

maciejbocianski mentioned this pull request Dec 13, 2018

K82F QSPI test fails intermittently #9075

Closed

Feature qspi kinetis #8485

Feature qspi kinetis #8485

Uh oh!

Conversation

mmahadevan108 commented Oct 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

mmahadevan108 commented Oct 19, 2018

Uh oh!

mmahadevan108 commented Oct 19, 2018

Uh oh!

cmonr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maciejbocianski Oct 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NirSonnenschein commented Oct 21, 2018

Uh oh!

mbed-ci commented Oct 21, 2018

Triggering tests

Uh oh!

mbed-ci commented Oct 21, 2018

Uh oh!

mbed-ci commented Oct 21, 2018

Uh oh!

NirSonnenschein commented Oct 21, 2018

Uh oh!

mbed-ci commented Oct 21, 2018

Uh oh!

cmonr commented Oct 22, 2018

Uh oh!

0xc0170 commented Oct 23, 2018

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

mmahadevan108 commented Oct 23, 2018

Uh oh!

cmonr commented Oct 23, 2018

Uh oh!

Uh oh!

mmahadevan108 commented Oct 19, 2018 •

edited

Loading

maciejbocianski Oct 23, 2018 •

edited

Loading