Skip to content

Fix minor typo in Timeout #8389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2018
Merged

Fix minor typo in Timeout #8389

merged 1 commit into from
Oct 13, 2018

Conversation

kegilbert
Copy link
Contributor

@kegilbert kegilbert commented Oct 11, 2018

Description

Fix minor typo. First typo found in the WIP automated comment spell checker script.

@AnotherButler

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Question: Do docs changed typically just go under refactor? Should there be a doc option in the above list @adbridge ?

@AnotherButler
Copy link
Contributor

Nice work @kegilbert 🎉

@adbridge
Copy link
Contributor

@kegilbert I would say docs changes would currently go under 'Fix' but we will certainly think about whether we should have a separate type for those

@cmonr
Copy link
Contributor

cmonr commented Oct 12, 2018

@kegilbert I would say docs changes would currently go under 'Fix' but we will certainly think about whether we should have a separate type for those

We just merged in the template update, so new PRs will have []docs and []test options.

@cmonr cmonr merged commit a28d1c0 into master Oct 13, 2018
@0xc0170 0xc0170 deleted the kegilbert-patch-1 branch October 22, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants