Skip to content

Reduce cellular memory footprint #8313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2018
Merged

Reduce cellular memory footprint #8313

merged 2 commits into from
Oct 23, 2018

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Oct 3, 2018

Description

Reduce cellular ROM usage with some optimizations. With ARMC5 this reduces cellular object size ~300Bytes and with GCC_ARM ~1kB.

Internal ref: IOTCELL-1120

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@kivaisan
Copy link
Contributor Author

kivaisan commented Oct 3, 2018

@AriParkkila @mirelachirica @jarvte please review.

@kivaisan kivaisan changed the title Reduce memory footprint Reduce cellular memory footprint Oct 3, 2018
jarvte
jarvte suggested changes Oct 4, 2018
View reviewed changes
features/cellular/UNITTESTS/stubs/ATHandler_stub.cpp
@@ -279,6 +279,13 @@ void ATHandler::cmd_stop()
{
}

void ATHandler::cmd_stop_read_resp()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't these old files just be deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarvte If these old unit tests can be removed, maybe those could be done with a own PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me

@cmonr
Copy link
Contributor

cmonr commented Oct 18, 2018

@kivaisan Once rebased, we should be good to start CI

@kivaisan
Copy link
Contributor Author

@cmonr Rebased.

@cmonr
Copy link
Contributor

cmonr commented Oct 19, 2018

Strange. @kivaisan Could you take a look at the test failures?

Kimmo Vaisanen added 2 commits October 22, 2018 08:35
Cellular: Optimize memory usage for gsm_to_ascii table
553718b 
gsm_to_ascii table contains ASCII codes, so it can be a char table instead of int table.

This reduces ROM usage by 384 bytes.
Cellular: Refactor basic AT command stop and response reading into ow…
963bf81 
…n method

This reduces ROM usage by few hundred bytes.
@kivaisan
Copy link
Contributor Author

@cmonr, fixed.

@cmonr
Copy link
Contributor

cmonr commented Oct 23, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 23, 2018

Build : SUCCESS

Build number : 3431
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8313/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 23, 2018

Exporter Build : FAILURE

Build number : 3052
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8313/

@mbed-ci
Copy link

mbed-ci commented Oct 23, 2018

Test : SUCCESS

Build number : 3221
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8313/3221

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 23, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 23, 2018

Exporter Build : SUCCESS

Build number : 3056
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8313/

@cmonr cmonr merged commit 69904ea into ARMmbed:master Oct 23, 2018
@adbridge
Copy link
Contributor

adbridge commented Nov 2, 2018

This sits on top of changes scheduled for 5.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@jarvte jarvte jarvte approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kivaisan @cmonr @mbed-ci @0xc0170 @adbridge @jarvte @NirSonnenschein