Skip to content

Use wait_ms(int) instead of wait(float) #8302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2018
Merged

Use wait_ms(int) instead of wait(float) #8302

merged 1 commit into from
Oct 17, 2018

Conversation

JanneKiiskila
Copy link
Contributor

Small space savings, the casting from int to float will bloat
the code a bit. Using wait(1.0f) for example would avoid it,
but seems a bit silly to use floats for anything unless
really needed (in embedded products).

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@JanneKiiskila JanneKiiskila changed the title Use wait_ms instead of wait(n) Use wait_ms(int) instead of wait(float) Oct 3, 2018
@JanneKiiskila
Copy link
Contributor Author

@0xc0170 @adbridge

@0xc0170 0xc0170 requested review from a team and removed request for a team October 4, 2018 12:17
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 11, 2018

Ready for CI , can you rebase to resolve the conflict please?

Use wait_ms instead of wait(n)
de77695 
Small space savings, the casting from int to float will bloat
the code a bit. Using wait(1.0f) for example would avoid it,
but seems a bit silly to use floats for anything unless
really needed (in embedded products).
@JanneKiiskila
Copy link
Contributor Author

Rebased, git resolved it with a 3-way merge automatically.

@cmonr
Copy link
Contributor

cmonr commented Oct 17, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 17, 2018

Build : SUCCESS

Build number : 3379
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8302/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 17, 2018

Exporter Build : SUCCESS

Build number : 3014
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8302/

@mbed-ci
Copy link

mbed-ci commented Oct 17, 2018

Test : SUCCESS

Build number : 3184
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8302/3184

@cmonr cmonr merged commit 2daab38 into ARMmbed:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@M-ichae-l M-ichae-l M-ichae-l approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JanneKiiskila @0xc0170 @cmonr @mbed-ci @M-ichae-l