Skip to content

Cellular: Update Cinterion AT drivers #8295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2018
Merged

Cellular: Update Cinterion AT drivers #8295

merged 1 commit into from
Oct 15, 2018

Conversation

AriParkkila
Copy link

@AriParkkila AriParkkila commented Oct 2, 2018 •
edited
Loading

Description

Fixed how AT drivers for Gemalto/Cinterion cellular module close internet service and profile.

GitHub issue #8195

Arm internal ref IOTCELL-1420, IOTCELL-1442

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@AriParkkila
Copy link
Author

@mirelachirica @jarvte please review

@AriParkkila AriParkkila mentioned this pull request Oct 2, 2018
Closed
@0xc0170 0xc0170 requested a review from a team October 2, 2018 08:20
@0xc0170 0xc0170 changed the title Cellular: Updated Cinterion AT drivers Cellular: Update Cinterion AT drivers Oct 4, 2018
0xc0170
0xc0170 requested changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed how AT drivers for Gemalto/Cinterion cellular module close internet service and profile.
GitHub issue #8195
Arm internal ref IOTCELL-1420, IOTCELL-1442

Can this be captured in the commit ? More valuable than in only in github comment

@AriParkkila
Copy link
Author

@0xc0170 fixed commit message more descriptive

@NirSonnenschein
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 14, 2018

Build : SUCCESS

Build number : 3349
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8295/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 14, 2018

Exporter Build : SUCCESS

Build number : 2982
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8295/

@mbed-ci
Copy link

mbed-ci commented Oct 14, 2018

Test : SUCCESS

Build number : 3154
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8295/3154

@cmonr cmonr merged commit a9f4323 into ARMmbed:master Oct 15, 2018
@adbridge
Copy link
Contributor

This sits on top of #7969 which is scheduled for 5.11 so also pushing this one out

@adbridge adbridge mentioned this pull request Nov 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jarvte jarvte jarvte approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AriParkkila @NirSonnenschein @mbed-ci @adbridge @0xc0170 @jarvte @cmonr