Registration parameters as struct #8114

mirelachirica · 2018-09-13T10:50:12Z

Description

More registration parameters needed to be supported so struct to hold all the parameters was created.

This PR includes also one commit with the AT handler fix needed/noticed when reading some of the registration parameters.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

mirelachirica · 2018-09-13T11:26:15Z

@AriParkkila and @jarvte please review.

jarvte · 2018-09-18T06:41:42Z

features/cellular/framework/AT/AT_CellularNetwork.cpp

+int AT_CellularNetwork::calculate_periodic_tau(const char *periodic_tau_string, int periodic_tau_length)
+{
+    if (periodic_tau_length != ONE_BYTE_BINARY)
+    {


coding conventions.

jarvte · 2018-09-18T06:42:01Z

features/cellular/framework/AT/AT_CellularNetwork.cpp

+int AT_CellularNetwork::calculate_active_time(const char *active_time_string, int active_time_length)
+{
+    if (active_time_length != ONE_BYTE_BINARY)
+    {


coding conventions.

mirelachirica · 2018-09-20T11:30:58Z

Rebased but not Unit Tested.

cmonr · 2018-09-20T15:48:45Z

@mirelachirica @jarvte Why were the virtual functions removed?

ac0e211#diff-3bd850d652d556508775518fdd56d09f

mirelachirica · 2018-09-21T06:28:37Z

They were replaced with get_registration_params(...). Registration parameters to be retrieved via registration_params_t object.

0xc0170 · 2018-09-21T08:02:14Z

This type of refactor (does not actually fix anything - there is one fix in here that might be a separate patch?) should be for 5.11 ?

mirelachirica · 2018-09-21T09:07:21Z

Yes it is 5.11 change. More parameters needed to be retrieved so now they are in one structure. There was also a bug in ATHandler when reading these parameters. That is fixed in separate commit.

mirelachirica · 2018-09-24T07:17:59Z

Updated -> google unit tests passing

0xc0170 · 2018-09-24T07:44:11Z

Updated -> google unit tests passing

unittest CI failed, pls review

mirelachirica · 2018-09-24T07:51:47Z

Just noticed this problem on master already. Will check it.

0xc0170 · 2018-09-24T09:28:13Z

I noticed it as well in another PR, not certain how it got in (if there is a bug on master now). Thanks for looking at it

mirelachirica · 2018-09-24T09:40:48Z

When these unit tests started being part of CI?
Should fix for this problem be part of this PR or should there be separate PR?

mirelachirica · 2018-09-24T09:54:29Z

I will generate new PR to include also another fix for features-cellular-framework-common-util.exe test. This common-util error is not seen in master but I have seen it on friday and is due to not null terminated string defined in unit test which might cause unstable behaviour.

mirelachirica · 2018-09-24T10:17:54Z

PR to fix the failure: #8229

mirelachirica · 2018-09-26T10:33:48Z

This needs to proceed. @AriParkkila @AnttiKauppila can you please review?

NirSonnenschein · 2018-10-04T06:49:04Z

/morph build

mbed-ci · 2018-10-04T07:37:14Z

Build : FAILURE

Build number : 3229
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8114/

0xc0170 · 2018-10-04T10:12:07Z

/morph build

mbed-ci · 2018-10-04T11:59:11Z

Build : SUCCESS

Build number : 3232
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8114/

Triggering tests

/morph test
/morph mbed2-build

mbed-ci · 2018-10-04T16:38:09Z

Test : FAILURE

Build number : 3035
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8114/3035

0xc0170 · 2018-10-05T13:18:23Z

I restarted Travis, previously failed to report back the status.

cmonr · 2018-10-08T18:52:57Z

This needs a rebase.

mirelachirica · 2018-10-09T08:21:45Z

rebased

cmonr · 2018-10-09T15:03:26Z

/morph build

mbed-ci · 2018-10-09T15:52:04Z

Build : SUCCESS

Build number : 3296
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8114/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-09T16:51:05Z

Exporter Build : SUCCESS

Build number : 2924
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8114/

mbed-ci · 2018-10-09T23:27:22Z

Test : SUCCESS

Build number : 3105
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8114/3105

cmonr added needs: review release-version: 5.10.1 labels Sep 13, 2018

jarvte reviewed Sep 18, 2018

View reviewed changes

mirelachirica force-pushed the registration_params_2 branch from 8694338 to eaf47e1 Compare September 18, 2018 07:23

jarvte approved these changes Sep 18, 2018

View reviewed changes

mirelachirica force-pushed the registration_params_2 branch from eaf47e1 to ac0e211 Compare September 20, 2018 11:29

0xc0170 added release-version: 5.11.0-rc1 and removed release-version: 5.10.1 labels Sep 21, 2018

mirelachirica force-pushed the registration_params_2 branch from ac0e211 to e8e7d2a Compare September 24, 2018 07:14

mirelachirica force-pushed the registration_params_2 branch from e8e7d2a to c721b31 Compare September 26, 2018 10:09

0xc0170 requested review from AnttiKauppila and AriParkkila September 26, 2018 10:36

AnttiKauppila approved these changes Sep 26, 2018

View reviewed changes

mirelachirica force-pushed the registration_params_2 branch from c721b31 to 127f4e2 Compare September 26, 2018 13:24

cmonr added the needs: CI label Sep 26, 2018

cmonr removed the needs: review label Sep 26, 2018

0xc0170 approved these changes Oct 1, 2018

View reviewed changes

cmonr added needs: work and removed needs: CI labels Oct 8, 2018

Mirela Chirica added 2 commits October 9, 2018 10:47

Cellular: AT handler read string up to delimiter or stop tag

723e913

Cellular: Registration parameters as struct

ffb9cdb

mirelachirica force-pushed the registration_params_2 branch from 127f4e2 to ffb9cdb Compare October 9, 2018 08:18

cmonr added needs: CI and removed needs: work labels Oct 9, 2018

0xc0170 added ready for merge and removed needs: CI labels Oct 9, 2018

cmonr merged commit 70252f8 into ARMmbed:master Oct 10, 2018

cmonr removed the ready for merge label Oct 10, 2018

Registration parameters as struct #8114

Registration parameters as struct #8114

Uh oh!

Conversation

mirelachirica commented Sep 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

mirelachirica commented Sep 13, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mirelachirica commented Sep 20, 2018

Uh oh!

cmonr commented Sep 20, 2018

Uh oh!

mirelachirica commented Sep 21, 2018

Uh oh!

0xc0170 commented Sep 21, 2018

Uh oh!

mirelachirica commented Sep 21, 2018

Uh oh!

mirelachirica commented Sep 24, 2018

Uh oh!

0xc0170 commented Sep 24, 2018

Uh oh!

mirelachirica commented Sep 24, 2018

Uh oh!

0xc0170 commented Sep 24, 2018

Uh oh!

mirelachirica commented Sep 24, 2018

Uh oh!

mirelachirica commented Sep 24, 2018

Uh oh!

mirelachirica commented Sep 24, 2018

Uh oh!

mirelachirica commented Sep 26, 2018

Uh oh!

NirSonnenschein commented Oct 4, 2018

Uh oh!

mbed-ci commented Oct 4, 2018

Uh oh!

0xc0170 commented Oct 4, 2018

Uh oh!

mbed-ci commented Oct 4, 2018

Triggering tests

Uh oh!

mbed-ci commented Oct 4, 2018

Uh oh!

0xc0170 commented Oct 5, 2018

Uh oh!

cmonr commented Oct 8, 2018

Uh oh!

mirelachirica commented Oct 9, 2018

Uh oh!

cmonr commented Oct 9, 2018

Uh oh!

mbed-ci commented Oct 9, 2018

Triggering tests

Uh oh!

mbed-ci commented Oct 9, 2018

Uh oh!

mbed-ci commented Oct 9, 2018

Uh oh!

Uh oh!

mirelachirica commented Sep 13, 2018 •

edited

Loading