-
Notifications
You must be signed in to change notification settings - Fork 3k
Removed cellular PIN code print from debug log. #8057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you explain a reason for this? I guess security might be your concern, but that's not a very valid point here because in R&D developer already knows PIN and in production builds debug prints are not enabled. |
@korjaa this change is OK, but I'd like to understand if you can explain some reason for this? |
@korjaa Any update or should be closed ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is as per Security Requirements: Sensitive data must not be logged.
Sorry, I've been only monitoring the JIRA ticket. I still think this needs to go in and I will close the JIRA ticket when this is merged. |
aea7c8a
to
473ac20
Compare
rebased. |
/morph build |
Build : SUCCESSBuild number : 3218 Triggering tests/morph test |
/morph test |
/morph export-build |
Exporter Build : FAILUREBuild number : 2860 |
/morph export-build |
Exporter Build : FAILUREBuild number : 2866 |
/morph export-build |
/morph test |
Exporter Build : SUCCESSBuild number : 2878 |
Description
Removed cellular PIN code print from debug log.
Pull request type