Skip to content

Removed cellular PIN code print from debug log. #8057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

korjaa
Copy link
Contributor

@korjaa korjaa commented Sep 10, 2018

Description

Removed cellular PIN code print from debug log.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@cmonr cmonr requested review from a user and AriParkkila September 10, 2018 15:50
@AriParkkila
Copy link

Can you explain a reason for this? I guess security might be your concern, but that's not a very valid point here because in R&D developer already knows PIN and in production builds debug prints are not enabled.

@AriParkkila
Copy link

@korjaa this change is OK, but I'd like to understand if you can explain some reason for this?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 24, 2018

@korjaa Any update or should be closed ?

Copy link

@AriParkkila AriParkkila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is as per Security Requirements: Sensitive data must not be logged.

@korjaa
Copy link
Contributor Author

korjaa commented Sep 25, 2018

Sorry, I've been only monitoring the JIRA ticket. I still think this needs to go in and I will close the JIRA ticket when this is merged.

@korjaa korjaa force-pushed the remove_sim_pin_print branch from aea7c8a to 473ac20 Compare October 1, 2018 06:11
@korjaa
Copy link
Contributor Author

korjaa commented Oct 1, 2018

rebased.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 2, 2018

Build : SUCCESS

Build number : 3218
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8057/

Triggering tests

/morph test
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 3, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 5, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 6, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

@NirSonnenschein
Copy link
Contributor

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

@NirSonnenschein
Copy link
Contributor

/morph export-build

@studavekar
Copy link
Contributor

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

@cmonr cmonr merged commit b153bb3 into ARMmbed:master Oct 8, 2018
@korjaa korjaa deleted the remove_sim_pin_print branch February 14, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants