-
Notifications
You must be signed in to change notification settings - Fork 3k
LoRaWAN: Memory overrun correction #7982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A typo in LoRaPHYCN470 is causing memory overrun. We were supposed to fill-in default channel mask and iterate over CN470_CHANNEL_MASK_SIZE times.
@0xc0170 @kjbracey-arm Please review. This needs immediate CI and merge. |
/morph build |
Build : SUCCESSBuild number : 3042 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2658 |
@hasnainvirk Will restart both export and test CI in a bit. Current queues a bit long. |
@cmonr Have we missed this again ?? This is a broken , we must get this PR in as fast as we can. It's been about 8 days now, this PR is just a one liner ! |
@hasnainvirk We missed this because we've been prioritizing PRs needed for 5.10 RCs. /morph test |
Exporter Build : SUCCESSBuild number : 2672 |
@cmonr Could you please reconsider this to be part of 5.10.0? This is a quite bad memory corruption bug. |
@cmonr This must go in as soon as possible. Please prioritise. |
@ChiefBureaucraticOfficer Could you please let us know if you think this should come in to 5.10 as requested by @hasnainvirk . AFAIK it has not been seen in OOB so would technically not normally be considered. |
If this is not critical/blocker, this will go 5.10.1. This is now going in, the label can be updated on request. |
Description
A typo in LoRaPHYCN470 is causing memory overrun.
We were supposed to fill-in default channel mask and iterate over CN470_CHANNEL_MASK_SIZE times.
Pull request type