Skip to content

Nuvoton: Fix GPIO mode mapping #7941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2018
Merged

Nuvoton: Fix GPIO mode mapping #7941

merged 1 commit into from
Sep 25, 2018

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Aug 31, 2018

Description

Nuvoton's GPIO H/W doesn't support separate configuration for input pull mode (PinMode)/direction (PinDirection). It supports 3~4 GPIO I/O modes which include the above configurations. This PR tries to give a better mode mapping between input pull mode/direction and GPIO I/O mode in the functions gpio_mode/gpio_dir/pin_mode.

  • NUMAKER_PFM_NUC472
  • NUMAKER_PFM_M453
  • NUMAKER_PFM_M487
  • NUMAKER_PFM_NANO130
  • NUMAKER_PFM_M2351

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@ccli8
[Nuvoton] Fix pin mode mapping between input pull mode/direction and …
55328eb 
…I/O mode

1. Modify PinMode enum to fully support GPIO I/O modes.
2. Translate input pull mode/direction to I/O mode, where H/W doesn't support
   separate configuration for input pull mode/direction.
3. Allow for configuring I/O mode in addition to input pull mode.
@deepikabhavnani deepikabhavnani requested a review from a team September 21, 2018 17:07
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 24, 2018

Build : SUCCESS

Build number : 3153
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7941/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 24, 2018

Exporter Build : SUCCESS

Build number : 2757
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7941/

@mbed-ci
Copy link

mbed-ci commented Sep 25, 2018

Test : FAILURE

Build number : 2958
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7941/2958

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 25, 2018

@studavekar Again time_start failure for LPC546XX. Has this been reported already? Looks like this target has been unstable in the last 2-3 weeks. Can you create a ticket please?

@cmonr
Copy link
Contributor

cmonr commented Sep 25, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 25, 2018

Test : SUCCESS

Build number : 2963
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7941/2963

@cmonr cmonr merged commit 815683c into ARMmbed:master Sep 25, 2018
@cmonr cmonr removed the needs: CI label Sep 25, 2018
@ccli8 ccli8 deleted the nuvoton_fix_gpio_mode_mapping branch October 2, 2018 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@deepikabhavnani deepikabhavnani deepikabhavnani approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccli8 @0xc0170 @mbed-ci @cmonr @deepikabhavnani