-
Notifications
You must be signed in to change notification settings - Fork 3k
LoRa: Stop processing MAC commands if command id is unknown #7935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The length of a MAC command is not explicitly given and must be implicitly known by the MAC implementation. Therefore unknown MAC commands cannot be skipped and the first unknown MAC command terminates the processing of the MAC command sequence. This commit fixes the bug where MAC command processing was not terminated when unknown MAC command was received.
@hasnainvirk @AnttiKauppila please review. |
@kivaisan Please check why the build failed. |
Build failure does not seem to be related to this PR. |
Thanks @hasnainvirk. Travis jobs restarted. Silly network issues... |
/morph build |
Build : SUCCESSBuild number : 3113 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2720 |
Description
The length of a MAC command is not explicitly given and must be
implicitly known by the MAC implementation. Therefore unknown MAC
commands cannot be skipped and the first unknown MAC command
terminates the processing of the MAC command sequence.
This commit fixes the bug where MAC command processing was not
terminated when unknown MAC command was received.
Pull request type