Skip to content

LoRa: Stop processing MAC commands if command id is unknown #7935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2018
Merged

LoRa: Stop processing MAC commands if command id is unknown #7935

merged 1 commit into from
Sep 20, 2018

Conversation

kivaisan
Copy link
Contributor

Description

The length of a MAC command is not explicitly given and must be
implicitly known by the MAC implementation. Therefore unknown MAC
commands cannot be skipped and the first unknown MAC command
terminates the processing of the MAC command sequence.

This commit fixes the bug where MAC command processing was not
terminated when unknown MAC command was received.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

The length of a MAC command is not explicitly given and must be
implicitly known by the MAC implementation. Therefore unknown MAC
commands cannot be skipped and the first unknown MAC command
terminates the processing of the MAC command sequence.

This commit fixes the bug where MAC command processing was not
terminated when unknown MAC command was received.
@kivaisan
Copy link
Contributor Author

@hasnainvirk @AnttiKauppila please review.

@hasnainvirk
Copy link
Contributor

@kivaisan Please check why the build failed.

@kivaisan
Copy link
Contributor Author

Build failure does not seem to be related to this PR.

@hasnainvirk
Copy link
Contributor

@0xc0170 @cmonr Please invoke CI here.

@cmonr
Copy link
Contributor

cmonr commented Sep 10, 2018

Thanks @hasnainvirk. Travis jobs restarted. Silly network issues...

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 20, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2018

Build : SUCCESS

Build number : 3113
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7935/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2018

@cmonr cmonr merged commit 9346a7e into ARMmbed:master Sep 20, 2018
@cmonr cmonr removed the needs: CI label Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants