-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix Microlib compatibility for -t ARM #7722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Missing from common flags: * `-D__MICROLIB` * `--library_type=microlib` This patch adds them
I thought that microlib was only invoked within the ARM compiler when uARM was used. |
Also, is this fixing a particualr issue, or something you noticed and came across? |
This should be a fix (dont recall particular issue reported here though). I would have assumed only linker symbol is needed but if we build static lib, also |
/morph build |
Build : SUCCESSBuild number : 2760 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2389 |
Single failure appears to possibly be due to multiplicly defined asm symbols bug that crops up every once in a while. And DNS test has been on and off this week. |
/morph test |
Exporter Build : SUCCESSBuild number : 2397 |
/morph test |
Fix Microlib compatibility for -t ARM
Description
Missing from common flags:
-D__MICROLIB
--library_type=microlib
This patch adds them
Pull request type