Skip to content

FlashIAP: Add a ROM end macro #7705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2018
Merged

FlashIAP: Add a ROM end macro #7705

merged 1 commit into from
Aug 7, 2018

Conversation

davidsaada
Copy link
Contributor

Description

Add a macro for ROM end. To be used by flash related features, wishing to check whether code overlaps flash writes.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

@davidsaada davidsaada mentioned this pull request Aug 6, 2018
Merged
@0xc0170 0xc0170 requested review from a team and geky August 6, 2018 13:07
offirko
offirko reviewed Aug 6, 2018
View reviewed changes
drivers/FlashIAP.h
@@ -28,6 +28,20 @@
#include "platform/SingletonPtr.h"
#include "platform/PlatformMutex.h"
#include "platform/NonCopyable.h"
#include <algorithm>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be a bit of an overkill for 'max' - consider using a small macro/inline instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would agree if it was only used in the header file. However, as it is also used in the FlashIAP implementation, and assuming anyone that includes the header file would also use the FlashIAP class, then it shouldn't add any extra code.

geky
geky approved these changes Aug 6, 2018
View reviewed changes
Copy link
Contributor

@geky geky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@cmonr
Copy link
Contributor

cmonr commented Aug 6, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 6, 2018

Build : SUCCESS

Build number : 2746
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7705/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 6, 2018

Exporter Build : SUCCESS

Build number : 2377
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7705/

@mbed-ci
Copy link

mbed-ci commented Aug 6, 2018

Test : SUCCESS

Build number : 2470
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7705/2470

@cmonr
Copy link
Contributor

cmonr commented Aug 7, 2018

/morph mbed2-build

@0xc0170 0xc0170 removed the needs: CI label Aug 7, 2018
@cmonr cmonr merged commit b8727ec into ARMmbed:master Aug 7, 2018
@davidsaada davidsaada deleted the david_rom_end_macro branch August 22, 2018 09:08
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7705 from davidsaada/david_rom_end_macro
14af5c5 
FlashIAP: Add a ROM end macro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geky geky geky approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@offirko offirko offirko approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@davidsaada @cmonr @mbed-ci @geky @0xc0170 @offirko