Fixing import paths of memap.py when excuted as a script

[bridadan]

Description

This allows the memap.py script to be executed directly. On master, it currently throws an error:

$python mbed-os\tools\memap.py --help
Traceback (most recent call last):
  File "mbed-os\tools\memap.py", line 20, in <module>
    from .utils import (argparse_filestring_type, argparse_lowercase_hyphen_type,
ValueError: Attempted relative import in non-package

This patch was tested with Python version 2.7.13.

FYI @dlfryar

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

[dlfryar-zz]

cc: @jflynn129

[cmonr]

LGTM, but what I don't get is why other tools aren't affected in the same way. An example: https://github.com/ARMmbed/mbed-os/blob/master/tools/build_api.py#L36

[bridadan]

I believe its because those files aren't directly invoked. Instead, they're imported by the "front-line" scripts (make.py, build.py, etc). memap.py can be one of these "front-line" scripts, however its typically just called by make.py via the build_project() function:

mbed-os/tools/build_api.py

Lines 566 to 582 in 8755e56

	memap_instance = getattr(toolchain, 'memap_instance', None)
	memap_table = ''
	if memap_instance:
	# Write output to stdout in text (pretty table) format
	memap_table = memap_instance.generate_output('table', stats_depth)
	notify.info(memap_table)
	# Write output to file in JSON format
	map_out = join(build_path, name + "_map.json")
	memap_instance.generate_output('json', stats_depth, map_out)
	# Write output to file in CSV format for the CI
	map_csv = join(build_path, name + "_map.csv")
	memap_instance.generate_output('csv-ci', stats_depth, map_csv)
	map_html = join(build_path, name + "_map.html")
	memap_instance.generate_output('html', stats_depth, map_html)

The frontline scripts add the proper directories to the path so all the imported files get the same path.

[theotherjimmy]

Correct indentation please.

[bridadan]

Ok, I updated it to match build_api.py.

[cmonr]

Interesting. @bridadan please take a look at the travis failure.
@geky Would you happen to know why this PR failed the particular littlefs test?

PR updated.

[geky]

Would you happen to know why this PR failed the particular littlefs test?

Do you mean the equeue test?

It's a little test of the internal event queue logic using POSIX calls. This was probably a mistake, because if Travis is under heavy load or just not processing jobs, the timing functions can sway >100ms and cause the tests to fail. Last time this happened was ~5 months ago. We should move the equeue tests to just simulate the timer on a tick.

[cmonr]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 2797
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7673/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 2427
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7673/

[cmonr]

/morph test

[cmonr]

Crud. Looks like this needs a rebase.

[bridadan]

Rebased!

[0xc0170]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 2844
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7673/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 2471
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7673/

[mbed-ci]

Test : FAILURE

Build number : 2595
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7673/2595

[0xc0170]

/morph test

[mbed-ci]

Test : FAILURE

Build number : 2602
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7673/2602

[cmonr]

Timing failure points to issue not being with PR.

/morph test

[mbed-ci]

Test : FAILURE

Build number : 2616
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7673/2616

[0xc0170]

/morph test

[mbed-ci]

Test : SUCCESS

Build number : 2643
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7673/2643

[adbridge]

Based on top of changes that only went into 5.10 and this fix will already be present there.