-
Notifications
You must be signed in to change notification settings - Fork 3k
NRF5x: Fix config of LFCLK source / settings. #7652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -40,21 +40,58 @@ | |||
|
|||
#ifndef MBED_CONF_NORDIC_NRF_LF_CLOCK_SRC | |||
#define MBED_CONF_NORDIC_NRF_LF_CLOCK_SRC (NRF_LF_SRC_XTAL) | |||
#warning No configuration for LF clock source. Xtal source will be used as a default configuration. | |||
#error No configuration for LF clock source. Xtal source will be used as a default configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this error now? The text indicates that default config would be used (should not be an error?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, that was changed for debugging only, didn't mean to commit it. I'll fix in the morning.
@marcuschangarm Mind taking a look? @andrewleech A reminder that this is still awaiting an update. |
Oh, yeah. I thought I did push that update, clearly not. |
@andrewleech Was there suppose to be an update commit attached to your last comment? |
6cdb6d1
to
e9b0c38
Compare
It's pushed now |
e9b0c38
to
74b65f5
Compare
/morph build |
Build : FAILUREBuild number : 2787 |
Drats, I'll look into the build fails next week as well then |
74b65f5
to
6293572
Compare
Ok that previous build failure should be fixed. I'd stripped out some old defines I erroneously thought were no longer used. |
/morph build |
Build : SUCCESSBuild number : 2860 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2490 |
/morph mbed2-build |
Description
The NRF5x targets all have config entries to set the low frequency clock source and a couple of settings for the RC source.
https://github.com/ARMmbed/mbed-os/blob/6634e4606d49c298be896cdf3c8aa9942067c5a2/targets/TARGET_NORDIC/TARGET_NRF5x/LF_Clock_config.md
https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L3744
The defines these map through to no longer exist in SDK14 / TARGET_NRF5x however:
https://github.com/ARMmbed/mbed-os/blob/2104d8ab5b6be5ce382b3b0e74085e1c2c677f85/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NRF52/source/btle/btle_clock.h
Nordic changed their defines for these things to
NRF_SDH_CLOCK_LF_SRC
,NRF_SDH_CLOCK_LF_RC_CTIV
&NRF_SDH_CLOCK_LF_RC_TEMP_CTIV
which are currently hardcoded in each softdevicembed_lib.json