Skip to content

Tools: Drop quotes from makefiles #7503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2018
Merged

Conversation

theotherjimmy
Copy link
Contributor

Description

This is a pretty simple bug: including ' characters in the commands
within a Makefile can sometimes cause problems with certain shell
configurations on Windows. This PR removes the 's, as they are not
needed.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Copy link

@deepikabhavnani deepikabhavnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Linking works now with Makefile

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 13, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 13, 2018

Build : SUCCESS

Build number : 2598
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7503/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 13, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 14, 2018

@cmonr cmonr merged commit d4a0e6c into ARMmbed:master Jul 14, 2018
@0xc0170 0xc0170 removed the needs: CI label Jul 14, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants