Lora: Add support for runtime PHY selection #7430
Conversation
Instead of giving LoRaWANTimeHandler object as parameter for constructor, object is now given via own initialize() method. This change is needed for future refactoring where application can give own PHY object for LoRa stack.
|
@hasnainvirk, @kjbracey-arm, please review. |
features/lorawan/LoRaWANStack.h
Outdated
| * | ||
| */ | ||
| void bind_radio_driver(LoRaRadio &radio); | ||
| void bind_phy_and_radio_driver(LoRaRadio& radio, LoRaPHY &phy); |
There was a problem hiding this comment.
LoRaRadio& radio -> LoRaRadio &radio
features/lorawan/LoRaWANInterface.h
Outdated
| * @param phy A reference to user created PHY object. | ||
| * | ||
| */ | ||
| LoRaWANInterface(LoRaRadio& radio, LoRaPHY &phy); |
There was a problem hiding this comment.
Add doc for the first parameter as well.
|
@hasnainvirk please review again. |
features/lorawan/LoRaWANInterface.h
Outdated
| * @param radio A reference to radio object | ||
| * @param phy A reference to PHY object | ||
| */ | ||
| LoRaWANInterface(LoRaRadio& radio, LoRaPHY &phy); |
There was a problem hiding this comment.
Style fix here. LoRaRadio& radio -> LoRaRadio &radio
features/lorawan/LoRaWANStack.cpp
Outdated
| @@ -98,15 +98,16 @@ LoRaWANStack::LoRaWANStack() | |||
| /***************************************************************************** | |||
| * Public Methods * | |||
| ****************************************************************************/ | |||
| void LoRaWANStack::bind_radio_driver(LoRaRadio &radio) | |||
| void LoRaWANStack::bind_phy_and_radio_driver(LoRaRadio& radio, LoRaPHY &phy) | |||
There was a problem hiding this comment.
Style fix here. LoRaRadio &raido
| * | ||
| */ | ||
| void bind_radio_driver(LoRaRadio &radio); | ||
| void bind_phy_and_radio_driver(LoRaRadio &radio, LoRaPHY &phy); |
There was a problem hiding this comment.
Style fix LoRaRadio &radio
There was a problem hiding this comment.
This one is good already but I fixed some other radio style bugs.
To support custom PHY object, a new LoRaWANInterface constructor was added.
|
@kjbracey-arm Can you please spare some time to review this ? |
|
/morph build |
Build : SUCCESSBuild number : 2551 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2196 |
|
Looks good to go! |
Lora: Add support for runtime PHY selection
Description
Add support to set up lora stack using user given PHY object. This will enable PHY selection at run time (usefull for example to roaming devices).
Pull request type