-
Notifications
You must be signed in to change notification settings - Fork 3k
Bug fix for receive windows #7399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In rx_config(params) API we shouldn't check for radio state as radio may never get idle for a class C device. That check made sense only for class A. As the PHY layer have no conecpt of receive windows which is a MAC layer construct, we should remove the state check. The API will be changed later to void rx_config(params). In addition to that another bug is fixed in the open_rx2_windows() API. We should set the rx slot first before instantiating a test based on its value.
@kivaisan @AnttiKauppila @kjbracey-arm Please review. |
/morph build |
Build : SUCCESSBuild number : 2503 Triggering tests/morph test |
@0xc0170 We will need to redeploy CI for this PR. Aborted for exporter test for some reason. |
@OPpuolitaival Can you please tell me why is the exporter build failing ? |
/morph export-build |
Exporter Build : FAILUREBuild number : 2159 |
/morph export-build |
Exporter Build : SUCCESSBuild number : 2167 |
The use of |
Description
In rx_config(params) API we shouldn't check for radio state as radio may never get
idle for a class C device. That check made sense only for class A. As the PHY layer
have no conecpt of receive windows which is a MAC layer construct, we should remove the
state check.
The API will be changed later to void rx_config(params).
In addition to that another bug is fixed in the open_rx2_windows() API. We should set the rx slot
first before instantiating a test based on its value.
Pull request type