Skip to content

Bug fix for receive windows #7399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Conversation

hasnainvirk
Copy link
Contributor

Description

In rx_config(params) API we shouldn't check for radio state as radio may never get
idle for a class C device. That check made sense only for class A. As the PHY layer
have no conecpt of receive windows which is a MAC layer construct, we should remove the
state check.
The API will be changed later to void rx_config(params).

In addition to that another bug is fixed in the open_rx2_windows() API. We should set the rx slot
first before instantiating a test based on its value.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

In rx_config(params) API we shouldn't check for radio state as radio may never get
idle for a class C device. That check made sense only for class A. As the PHY layer
have no conecpt of receive windows which is a MAC layer construct, we should remove the
state check.
The API will be changed later to void rx_config(params).

In addition to that another bug is fixed in the open_rx2_windows() API. We should set the rx slot
first before instantiating a test based on its value.
@hasnainvirk
Copy link
Contributor Author

@kivaisan @AnttiKauppila @kjbracey-arm Please review.

@0xc0170 0xc0170 requested a review from a team July 2, 2018 16:11
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 3, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 3, 2018

Build : SUCCESS

Build number : 2503
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7399/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@hasnainvirk
Copy link
Contributor Author

@0xc0170 We will need to redeploy CI for this PR. Aborted for exporter test for some reason.

@mbed-ci
Copy link

mbed-ci commented Jul 3, 2018

@hasnainvirk
Copy link
Contributor Author

@OPpuolitaival Can you please tell me why is the exporter build failing ?

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 3, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jul 3, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

@cmonr
Copy link
Contributor

cmonr commented Jul 16, 2018

The use of _lora_phy.handle_receive(); is throwing this to 5.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants