Skip to content

Add names to Idle/timer thread #7296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Conversation

deepikabhavnani
Copy link

Description

User configurable option was added to CMSIS for Idle/timer thread names. ARM-software/CMSIS_5@aa7a332

With recent CMSIS upgrade in Mbed OS, we can have config name option as well.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

cmonr
cmonr previously approved these changes Jun 21, 2018
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cmonr
Copy link
Contributor

cmonr commented Jun 21, 2018

/morph build

@deepikabhavnani
Copy link
Author

CI Jenkins failure does not look related to this PR

[K64F GCC_ARM] Building project default (K64F, GCC_ARM)
[K64F GCC_ARM] Scan: GCC_ARM
[K64F GCC_ARM] Scan: default
[K64F GCC_ARM] Scan: FEATURE_STORAGE
[K64F GCC_ARM] Scan: FEATURE_LWIP
[K64F GCC_ARM] Compile [100.0%]: main.cpp
[K64F GCC_ARM] [Error] main.cpp@18,2: #error [NOT_SUPPORTED] MODEM_ON_BOARD should be set for this test to be functional
[K64F GCC_ARM] [Error] main.cpp@42,2: #error [NOT_SUPPORTED] A json configuration file is needed. Skipping this build.
[K64F GCC_ARM] [Error] main.cpp@68,8: 'OnboardCellularInterface' does not name a type
[K64F GCC_ARM] [Error] main.cpp@74,33: 'OnboardCellularInterface' was not declared in this scope
[K64F GCC_ARM] [Error] main.cpp@74,59: 'iface' was not declared in this scope
[K64F GCC_ARM] [Error] main.cpp@80,28: variable or field 'use_connection' declared void
[K64F GCC_ARM] [Error] main.cpp@80,28: 'OnboardCellularInterface' was not declared in this scope
[K64F GCC_ARM] [Error] main.cpp@80,54: 'driver' was not declared in this scope
[K64F GCC_ARM] [Error] main.cpp@81,29: variable or field 'drop_connection' declared void
[K64F GCC_ARM] [Error] main.cpp@81,29: 'OnboardCellularInterface' was not declared in this scope

@cmonr
Copy link
Contributor

cmonr commented Jun 21, 2018

@deepikabhavnani Yeah, the issues appear to be network test cases that failed. Waiting a bit before relaunching, since Jenkins CI is churning away.

@mbed-ci
Copy link

mbed-ci commented Jun 21, 2018

Build : SUCCESS

Build number : 2426
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7296/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 21, 2018

@cmonr
Copy link
Contributor

cmonr commented Jun 21, 2018

Aaaand this is gonna need a rebase...

@deepikabhavnani
Copy link
Author

Rebase done

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 22, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

Build : SUCCESS

Build number : 2430
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7296/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 22, 2018

@0xc0170 0xc0170 requested a review from a team June 22, 2018 11:12
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticking one of my TODO items :)

@cmonr cmonr merged commit bb74def into ARMmbed:master Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants