Skip to content

Provide default WiFi interfaces for Ublox and Realtek #7259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2018

Conversation

SeppoTakalo
Copy link
Contributor

Description

To allow application to choose default WiFi interface by calling WiFiInterface::get_default_instance() provide its implementation on these two targets.

Partially fixes:
#7257
#7246

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@SeppoTakalo
Copy link
Contributor Author

Please review:
@kjbracey-arm
@ARMmbed/team-ublox
@ARMmbed/team-realtek

@cmonr cmonr requested review from kjbracey and a team June 19, 2018 12:43
@cmonr
Copy link
Contributor

cmonr commented Jun 19, 2018

@SeppoTakalo Wasn't able to add @ARMmbed/team-ublox to the reviewers list for some reason.

@SeppoTakalo
Copy link
Contributor Author

Its fine if Kevin approve, for Ublox and Realtek this is just for information.

kjbracey
kjbracey previously approved these changes Jun 19, 2018
@cmonr
Copy link
Contributor

cmonr commented Jun 19, 2018

/morph build

@@ -0,0 +1,7 @@
#include "RTWInterface.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license headers add to the new files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@mbed-ci
Copy link

mbed-ci commented Jun 19, 2018

Build : SUCCESS

Build number : 2386
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7259/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 19, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 19, 2018

@cmonr
Copy link
Contributor

cmonr commented Jun 19, 2018

Restarting build since commits after the last command moved the PR's Head sha.
/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 19, 2018

Build : SUCCESS

Build number : 2389
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7259/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 19, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 19, 2018

@cmonr cmonr merged commit 567689c into ARMmbed:master Jun 20, 2018
@SeppoTakalo SeppoTakalo deleted the default_wifi branch June 25, 2018 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants