Cordio driver hook #7163
Cordio driver hook #7163
Conversation
A friend class living in the namespace ble::vendor::cordio and named CordioHCITransportDriver can be added in applications requiring access to internal data of the HCI driver and HCI transport driver. This is meant to be internal and not easily exploitable by application code.
| void CordioHCITransportDriver::on_data_received(uint8_t* data, uint16_t len) | ||
| { | ||
| hciTrSerialRxIncoming(data, len); |
There was a problem hiding this comment.
Right above; in the static member CordioHCITransportDriver::data_received_handler.
| void CordioHCITransportDriver::on_data_received(uint8_t* data, uint16_t len) | ||
| { | ||
| hciTrSerialRxIncoming(data, len); | ||
| while (len) { | ||
| uint8_t chunk_length = std::min(len, (uint16_t) std::numeric_limits<uint8_t>::max()); |
There was a problem hiding this comment.
It is a fix of an unnoticed but, the driver accept uint16_t as the size of data received while the cordio function only accepts uint8_t as the size argument.
| @@ -58,6 +58,10 @@ struct buf_pool_desc_t { | |||
| * - Access to the write function of the underlying HCITransport driver. | |||
| */ | |||
| class CordioHCIDriver { | |||
|
|
|||
| // hook for internal tests and passthrough driver | |||
| friend class CordioHCIHook; | |||
There was a problem hiding this comment.
not that I mind but why not just set the handler public?
There was a problem hiding this comment.
Encapsulation. Make interfaces easy to use correctly and hard to use incorrectly.
If it was public then it means that the system has been designed to support replacement of the RX handler; it hasn't and it won't! This would lead to disasters if application code was replacing the RX handler.
| void CordioHCITransportDriver::on_data_received(uint8_t* data, uint16_t len) | ||
| { | ||
| hciTrSerialRxIncoming(data, len); |
| void CordioHCITransportDriver::on_data_received(uint8_t* data, uint16_t len) | ||
| { | ||
| hciTrSerialRxIncoming(data, len); |
| void CordioHCITransportDriver::on_data_received(uint8_t* data, uint16_t len) | ||
| { | ||
| hciTrSerialRxIncoming(data, len); | ||
| while (len) { | ||
| uint8_t chunk_length = std::min(len, (uint16_t) std::numeric_limits<uint8_t>::max()); |
|
/morph build |
1 similar comment
|
/morph build |
Build : FAILUREBuild number : 2298 |
|
/morph build |
Build : SUCCESSBuild number : 2304 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1926 |
Description
This patch adds the necessary mechanisms to get access to the internals of the classes
CordioHCIDriverandCordioHCITransportDriver. With this change a class living in the namespaceble::vendor::cordioand namedCordioHCIHookcan get access to the internal of both classes mentioned above.This patch also allows dynamic override of the RX handler.
Note: It is not meant to be used by application; it will be used in internals tests.
Pull request type