Skip to content

Fixes for RZ_A1H issue 6543 #7151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Fixes for RZ_A1H issue 6543 #7151

merged 1 commit into from
Jun 13, 2018

Conversation

mrcoulter45
Copy link
Contributor

@mrcoulter45 mrcoulter45 commented Jun 6, 2018

Description

Code to fix build errors in issue 6543.
I have put debugging code in my remote https://github.com/mrcoulter45/mbed-os in the issue6543_debug branch. That code will build Blinky for the RZ_A1H with GCC_ARM and should be a good starting point for those who are implementing the low power ticker. In the debug code, the us ticker is being used as a substitute for the lp ticker.

Pull request type

[ x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@@ -20,12 +20,23 @@
* SOFTWARE.
*/
#include "rtos/TARGET_CORTEX/SysTimer.h"
#include "cmsis/TARGET_CORTEX_A/irq_ctrl.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this header file is not available for all cortex thus should be protected somehow. Thinking, isn't this irq_ctrl.h available via RTE_Components or CMSIS_device_header (in our case is it cmsis.h file) ?

I assume the same lines as in rtos/TARGET_CORTEX/mbed_rtx_idle.cpp would do the job here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed now.

void OS_Tick_Enable (void)
{
// Enable OS Tick.
// void OS_Tick_Enable (void)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these SDK files (thus only commented out) ? The ideal would be to have this removed, but if there is a reason to leave this dead code?

@theotherjimmy
Copy link
Contributor

@mrcoulter45 Nitpick on the description: you can enable "device has", but they can't be enabled for a particular toolchain. You may want to remove the mention of GCC_ARM from the description. Maybe you were trying to say that you verified with GCC_ARM?

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, but please remove the merge commit (cleanly rebase). This is a small changeset, one commit should be sufficient

@mrcoulter45 mrcoulter45 force-pushed the issue6543 branch 4 times, most recently from 1c71c6b to 8ece0f1 Compare June 11, 2018 17:18
Removed debugging code, fixed errors indicated in the comments.
@cmonr cmonr dismissed 0xc0170’s stale review June 12, 2018 03:18

Requests were addressed.

@cmonr
Copy link
Contributor

cmonr commented Jun 12, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 12, 2018

Build : SUCCESS

Build number : 2329
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7151/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 12, 2018

/morph mbed2-build

Copy link
Contributor

@TomoYamanaka TomoYamanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbed-ci
Copy link

mbed-ci commented Jun 12, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 12, 2018

Node failure, restarting

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jun 12, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 13, 2018

@cmonr cmonr merged commit 1cb298a into ARMmbed:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants