-
Notifications
You must be signed in to change notification settings - Fork 3k
Fixes for RZ_A1H issue 6543 #7151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rtos/TARGET_CORTEX/SysTimer.cpp
Outdated
@@ -20,12 +20,23 @@ | |||
* SOFTWARE. | |||
*/ | |||
#include "rtos/TARGET_CORTEX/SysTimer.h" | |||
#include "cmsis/TARGET_CORTEX_A/irq_ctrl.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this header file is not available for all cortex thus should be protected somehow. Thinking, isn't this irq_ctrl.h available via RTE_Components or CMSIS_device_header (in our case is it cmsis.h file) ?
I assume the same lines as in rtos/TARGET_CORTEX/mbed_rtx_idle.cpp would do the job here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed now.
void OS_Tick_Enable (void) | ||
{ | ||
// Enable OS Tick. | ||
// void OS_Tick_Enable (void) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these SDK files (thus only commented out) ? The ideal would be to have this removed, but if there is a reason to leave this dead code?
@mrcoulter45 Nitpick on the description: you can enable "device has", but they can't be enabled for a particular toolchain. You may want to remove the mention of GCC_ARM from the description. Maybe you were trying to say that you verified with GCC_ARM? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine, but please remove the merge commit (cleanly rebase). This is a small changeset, one commit should be sufficient
1c71c6b
to
8ece0f1
Compare
Removed debugging code, fixed errors indicated in the comments.
/morph build |
Build : SUCCESSBuild number : 2329 Triggering tests/morph test |
/morph mbed2-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Exporter Build : FAILUREBuild number : 1951 |
Node failure, restarting /morph export-build |
Exporter Build : SUCCESSBuild number : 1956 |
Description
Code to fix build errors in issue 6543.
I have put debugging code in my remote https://github.com/mrcoulter45/mbed-os in the issue6543_debug branch. That code will build Blinky for the RZ_A1H with GCC_ARM and should be a good starting point for those who are implementing the low power ticker. In the debug code, the us ticker is being used as a substitute for the lp ticker.
Pull request type