Nordic: Fix nrf sections on ARMCC #7150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nrf section features has different implementations for each compilers supported by mbed-os. The header guard was ruling out compiler other than GCC by checking if __GNUC__ is defined. This check is not applicable on mbed os as the ARM compiler compile sources with gnu compatibility. This patch makes sure that the right implementation is selected for the right compiler . The previous patch has been reverted as it is not reliable.
0xc0170
reviewed
Jun 7, 2018
| @@ -26,14 +26,10 @@ | |||
| LR_IROM1 MBED_APP_START MBED_APP_SIZE { | |||
| ER_IROM1 MBED_APP_START MBED_APP_SIZE { | |||
| *.o (RESET, +First) | |||
| *(InRoot$$Sections) | |||
| __start_sdh_soc_observers *(sdh_soc_observers) __stop_sdh_soc_observers | |||
There was a problem hiding this comment.
why are these lines being removed ( __start_xxx) ?
There was a problem hiding this comment.
Because they are not needed anymore; they were added with the first fix which wasn't reliable enough.
0xc0170
approved these changes
Jun 7, 2018
|
/morph build |
Build : SUCCESSBuild number : 2288 Triggering tests/morph test |
|
Pausing CI until 5.9 RC3 completes CI. Will restart jobs when able. |
|
/morph test |
Exporter Build : SUCCESSBuild number : 1913 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The nrf section features has different implementations for each compilers supported by mbed-os. The header guard was ruling out compiler other than GCC by checking if GNUC is defined. This check is not applicable on mbed os as the ARM compiler compile sources with gnu compatibility.
This patch makes sure that the right implementation is selected for the right compiler . The previous patch has been reverted as it is not reliable.
Pull request type