-
Notifications
You must be signed in to change notification settings - Fork 3k
Adding cellular tests #7102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding cellular tests #7102
Conversation
@0xc0170 Something wrong in ci pr-head which is not related to this pr |
@0xc0170 please proceed as this commit is used as a base for adding more tests. |
@0xc0170 could you please trigger the tests? |
/morph build |
Build : SUCCESSBuild number : 2317 Triggering tests/morph test |
@@ -18,8 +18,6 @@ | |||
#ifndef CELLULAR_LOG_H_ | |||
#define CELLULAR_LOG_H_ | |||
|
|||
#include "rtos.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for removing this include?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was unnecessary include which caused problems with stubbing the classes
Exporter Build : SUCCESSBuild number : 1940 |
@cmonr I guess co-morph-test failure not related to this pr: mbedgt: all tests finished! |
@jarvte That looks correct, I noticed this just now in another PR as well. I notified @studavekar I do not restart Ci immediately, waiting for current test to complete (if it fails or not) |
We're looking into some CI issues at the moment. The test will be restarted when the dust has settled. |
/morph test |
@cmonr Please merge so other can use this as a base for future tests. |
Description
Internal ref to defect: IOTCELL-884-893
@mirelachirica @AnttiKauppila please review
Pull request type