Skip to content

Edit warning about FEATURE_UVISOR being deprecated #7072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2018
Merged

Edit warning about FEATURE_UVISOR being deprecated #7072

merged 2 commits into from
Jun 4, 2018

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented May 31, 2018

Description

Edit uVisor deprecation warning.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@orenc17 orenc17 mentioned this pull request May 31, 2018
Merged
@orenc17
Copy link
Contributor Author

orenc17 commented May 31, 2018

CC @adbridge @iriark01 @cmonr @0xc0170

adbridge
adbridge requested changes May 31, 2018
View reviewed changes
features/FEATURE_UVISOR/includes/uvisor/api/inc/uvisor_deprecation.h Outdated
@@ -18,7 +18,8 @@
#define __UVISOR_DEPRECATION_H__

#if defined(UVISOR_PRESENT) && UVISOR_PRESENT == 1
#warning "Warning: You are using FEATURE_UVISOR, which is unsupported as of Mbed OS 5.9."
#warning "Warning: uVisor is superseded by the Secure Partition Manager (SPM) defined in the ARM Platform Security Architecture (PSA). \
uVisor is deprecated as of Mbed OS 5.9, and being replaced by a native PSA-compliant implementation of SPM."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should say 5.10. uvisor is still supported on the 5.9 branch so saying it is deprecated as of 5.9 is misleading.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then @ndevillard needs to reapprove the text with either 5.9 or 5.10

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please just comment the message that you would like and let's finish with this annoyance

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndevillard - I believe the agreement was deprecation notice in 5.9, actual deprecation in 5.10. So the notice should indicate 5.10.

Copy link
Contributor

@adbridge adbridge May 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orenc17 i think the 5.9 just needs to change to 5.10 and the rest is fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adbridge Done.

@cmonr
Copy link
Contributor

cmonr commented May 31, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 31, 2018

Build : SUCCESS

Build number : 2208
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7072/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 1, 2018

Test : SUCCESS

Build number : 2000
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7072/2000

@mbed-ci
Copy link

mbed-ci commented Jun 1, 2018

Exporter Build : SUCCESS

Build number : 1834
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7072/

@cmonr
Copy link
Contributor

cmonr commented Jun 3, 2018

ARM license issue.

Restarting pr-head.

@cmonr cmonr merged commit d559ed6 into ARMmbed:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@adbridge adbridge adbridge approved these changes

@iriark01 iriark01 Awaiting requested review from iriark01

Assignees
No one assigned
Labels
release-version: 5.9.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@orenc17 @cmonr @mbed-ci @0xc0170 @iriark01 @adbridge