Skip to content

gethostbyname must reject empty name #7054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2018
Merged

gethostbyname must reject empty name #7054

merged 2 commits into from
May 31, 2018

Conversation

VeijoPesonen
Copy link
Contributor

Considers both versions - synchronous and asynchronous. Earlier the
underlying stack was trusted to do this check.

Makes UDPSOCKET_SENDTO_INVALID part of the netsocket extended test set

Description

Greentea test cases TCPSOCKET_CONNECT_INVALID and UDPSOCKET_SENDTO_INVALID do fail without this modification. The issue was hidden due to the fact that TCPSOCKET_CONNECT_INVALID is part of the netsocket extended test set. The extended cases are not run in CI.

UDPSOCKET_SENDTO_INVALID was missing from the extended test set - fixed.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Veijo Pesonen added 2 commits May 30, 2018 12:07
Considers both versions - synchronous and asynchronous. Earlier the
underlying stack was trusted to do this check.
@VeijoPesonen
Copy link
Contributor Author

@SeppoTakalo, @kjbracey-arm and @mikaleppanen please review.

@0xc0170
Copy link
Contributor

0xc0170 commented May 30, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 30, 2018

Build : SUCCESS

Build number : 2194
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7054/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 30, 2018

@mbed-ci
Copy link

mbed-ci commented May 30, 2018

@cmonr cmonr merged commit 98a27a6 into ARMmbed:master May 31, 2018
@VeijoPesonen VeijoPesonen deleted the gethostbyname_empty_hostname_check branch June 4, 2018 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants