Skip to content

Cellular: AT debugging improved #6927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2018
Merged

Conversation

AriParkkila
Copy link

@AriParkkila AriParkkila commented May 16, 2018

Description

  • Removed function entry debug prints
  • AT debug is less noisy and it now prints also written chars
  • AT debug can be enabled using "cellular.debug-at" flag
  • Cellular log now has atomic locks for tracing
  • Changed non-fatal error prints to less severe
  • Fixed cellular Greentea tests
  • ATHandler::read was fixed to handle zero length string ""
  • Renamed enable_debug to set_debug, that's API change but only for debugging
  • Removed obsolete FEATURE_COMMON_PAL flag from trace (CI fixed on Lora: Remove obsolete FEATURE_COMMON_PAL flags #6905)

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@AriParkkila
Copy link
Author

@mirelachirica @jarvte please review

@0xc0170
Copy link
Contributor

0xc0170 commented May 16, 2018

@AriParkkila Please review astyle travis info about changes (it shows diff of style issues in touched files).

@AriParkkila
Copy link
Author

Please proceed with this.

@0xc0170
Copy link
Contributor

0xc0170 commented May 22, 2018

/morph build

@cmonr
Copy link
Contributor

cmonr commented May 23, 2018

Odd. Not sure why a failure wasn't reported.

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented May 23, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 23, 2018

Build : SUCCESS

Build number : 2126
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6927/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr
Copy link
Contributor

cmonr commented May 23, 2018

Shuffling around some jobs.

/morph export-build

@cmonr
Copy link
Contributor

cmonr commented May 23, 2018

/morph test

@cmonr
Copy link
Contributor

cmonr commented May 24, 2018

Performing another shuffle. Attempting to make sure #6993 is ready by the AM, if needed.

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 24, 2018

@cmonr
Copy link
Contributor

cmonr commented May 24, 2018

@AriParkkila Looks like this will need #6993 to pass. The test error is a newly discovered one that was found today.

That PR should be tested, merged, and ready to be rebased by the AM.

@mbed-ci
Copy link

mbed-ci commented May 24, 2018

@kjbracey
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented May 24, 2018

Build : SUCCESS

Build number : 2137
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6927/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 24, 2018

@mbed-ci
Copy link

mbed-ci commented May 24, 2018

@cmonr cmonr removed the needs: CI label May 24, 2018
@cmonr cmonr merged commit 5ce26b1 into ARMmbed:master May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants