Skip to content

Cellular: Add dynamic alloc and destruction to easycellular #6792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2018
Merged

Cellular: Add dynamic alloc and destruction to easycellular #6792

merged 1 commit into from
May 7, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented May 2, 2018 •
edited
Loading

Description

Added dynamic alloc and destruction to easycellular.
Now application can call connect and disconnect multiple times and resources are freed and constructed properly. Also whole easycellular can be deleted and constructed again.

Internal ref to defect: IOTCELL-814

@AriParkkila please review

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from AriParkkila May 2, 2018 13:44
@0xc0170 0xc0170 changed the title Cellular: Added dynamic alloc and destruction to easycellular. Cellular: Add dynamic alloc and destruction to easycellular May 3, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented May 3, 2018

The commit does not specify why this is being added? Is it really a fix - what does it fix?

After checking, IOTCELL-814, its more clear - thus this should be captured in the commit.

0xc0170
0xc0170 requested changes May 3, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extend the commit message what is this fixing and how (looking at the changes, I am not certain this is a fix or introducing a new feature to the implementation)

@jarvte
Copy link
Contributor Author

jarvte commented May 3, 2018

@0xc0170 updated commit message. This goes to 5.9 so fix/feature are both fine by me.

@0xc0170
Copy link
Contributor

0xc0170 commented May 3, 2018 •
edited
Loading

@0xc0170 updated commit message. This goes to 5.9 so fix/feature are both fine by me.

Please push it to the branch, don't see it yet.

Add instead of Added (see our guidelines in the handbook for the commit messages)

Cellular: Added dynamic alloc and destruction to easycellular.
b22a16f 
Now application can call connect and disconnect multiple times and resources are freed and constructed properly.
Also whole easycellular can be deleted and constructed again.
@jarvte jarvte force-pushed the cellular_dynamic_alloc_and_destr branch from 1ae82ae to b22a16f Compare May 3, 2018 09:49
@jarvte
Copy link
Contributor Author

jarvte commented May 3, 2018

@0xc0170 sorry, updated PR description only, now also commit message...

AriParkkila
AriParkkila approved these changes May 4, 2018
View reviewed changes
features/cellular/framework/AT/ATHandler.cpp
@@ -153,7 +150,20 @@ FileHandle *ATHandler::get_file_handle()

void ATHandler::set_file_handle(FileHandle *fh)
{
_fh_sigio_set = false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If _fileHandle already has sigio set that should be removed?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answering my own question above. We have internal ticket IOTCELL-846 for that. This PR looks good.

@0xc0170
Copy link
Contributor

0xc0170 commented May 4, 2018

We will start CI once one important fix completes (master is affected).

@jarvte
Copy link
Contributor Author

jarvte commented May 7, 2018

@0xc0170 fix done? Could morph be started?

@0xc0170
Copy link
Contributor

0xc0170 commented May 7, 2018

yes, starting now

/morph build

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

Build : SUCCESS

Build number : 1924
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6792/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

Test : SUCCESS

Build number : 1745
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6792/1745

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

Exporter Build : FAILURE

Build number : 1569
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6792/

@0xc0170
Copy link
Contributor

0xc0170 commented May 7, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

Exporter Build : SUCCESS

Build number : 1573
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6792/

@cmonr cmonr merged commit 7a1ab18 into ARMmbed:master May 7, 2018
@jarvte jarvte deleted the cellular_dynamic_alloc_and_destr branch May 8, 2018 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AriParkkila AriParkkila AriParkkila approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jarvte @0xc0170 @mbed-ci @AriParkkila @cmonr