-
Notifications
You must be signed in to change notification settings - Fork 3k
Rework us_ticker and rtc_api/lp_ticker | Fix compiler warning for spi_api #6605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…i_api Simplify tickers to stop emulating 1us ticks by using native timer resolutions. Implement ticker get info functions. Separate rtc and lp ticker init status by implementing separate functions. Add mbed_critical include file to disable compiler warning messages.
I approved the code changes. Looking at the commit message, these might be separate commits. At least the last one is not related to the tickers update. Please separate logical changes Please review and let us know if any corrections done, we will trigger CI then |
…s for spi_api" This reverts commit 840246a.
Simplify tickers to stop emulating 1us ticks by using native timer resolutions. Implement ticker get info functions. Separate rtc and lp ticker init status by implementing separate functions.
Add mbed_critical include file to disable compiler warning messages.
I committed the changes as separate commits. Can you please trigger CI? |
Appreciate it 👍 /morph build |
Build : SUCCESSBuild number : 1739 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1373 |
/morph mbed2-build |
@@ -1,5 +1,5 @@ | |||
/******************************************************************************* | |||
* Copyright (C) 2016 Maxim Integrated Products, Inc., All Rights Reserved. | |||
* Copyright (C) 2016,2018 Maxim Integrated Products, Inc., All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Is this a valid license header? I've never seen one with the years split like this.
/morph mbed2-build |
Description
Fix issue: #5309
Simplify tickers to stop emulating 1us ticks by using native timer resolutions.
Implement ticker get info functions.
Separate rtc and lp ticker init status by implementing separate functions.
Add mbed_critical include file to disable compiler warning messages.
Tested all supported toolchains with MAX32625MBED.
Pull request type
[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change