Skip to content

Rework us_ticker and rtc_api/lp_ticker | Fix compiler warning for spi_api #6605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from Apr 16, 2018
Merged

Rework us_ticker and rtc_api/lp_ticker | Fix compiler warning for spi_api #6605

merged 4 commits into from Apr 16, 2018

Conversation

khariya
Copy link
Contributor

@khariya khariya commented Apr 11, 2018

Description

Fix issue: #5309

Simplify tickers to stop emulating 1us ticks by using native timer resolutions.
Implement ticker get info functions.
Separate rtc and lp ticker init status by implementing separate functions.
Add mbed_critical include file to disable compiler warning messages.

Tested all supported toolchains with MAX32625MBED.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

…i_api

Simplify tickers to stop emulating 1us ticks by using native timer resolutions.
Implement ticker get info functions.
Separate rtc and lp ticker init status by implementing separate functions.
Add mbed_critical include file to disable compiler warning messages.
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 12, 2018

Simplify tickers to stop emulating 1us ticks by using native timer resolutions.
Implement ticker get info functions.
Separate rtc and lp ticker init status by implementing separate functions.
Add mbed_critical include file to disable compiler warning messages.

I approved the code changes. Looking at the commit message, these might be separate commits. At least the last one is not related to the tickers update. Please separate logical changes

Please review and let us know if any corrections done, we will trigger CI then

Keyur Hariya added 3 commits April 12, 2018 12:51
Simplify tickers to stop emulating 1us ticks by using native timer resolutions.
Implement ticker get info functions.
Separate rtc and lp ticker init status by implementing separate functions.
Add mbed_critical include file to disable compiler warning messages.
@khariya
Copy link
Contributor Author

khariya commented Apr 12, 2018

I committed the changes as separate commits. Can you please trigger CI?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 13, 2018

Appreciate it 👍

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 13, 2018

Build : SUCCESS

Build number : 1739
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6605/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 13, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 13, 2018

@cmonr
Copy link
Contributor

cmonr commented Apr 13, 2018

/morph mbed2-build

@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (C) 2016 Maxim Integrated Products, Inc., All Rights Reserved.
* Copyright (C) 2016,2018 Maxim Integrated Products, Inc., All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Is this a valid license header? I've never seen one with the years split like this.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 16, 2018

/morph mbed2-build

@cmonr cmonr merged commit 63412bb into ARMmbed:master Apr 16, 2018
@khariya khariya deleted the max32625-rework-ticker branch April 18, 2018 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants