Skip to content

Error on invalid mbed_lib JSON #6552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Apr 5, 2018

Description

Resolves #5908

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 6, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 6, 2018

Build : SUCCESS

Build number : 1671
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6552/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 6, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 6, 2018

@adbridge
Copy link
Contributor

adbridge commented Apr 11, 2018

@theotherjimmy The proforma for this PR has been modified again! This will break our automation script once it goes live. Please do not remove the 'Description' or 'Pull request type' headers and please use a 'X' in the checkbox rather than a tick!
Also the description should summarise the change, not just say fixes #xxxxx
I have updated this for now to show how it should look.

@mbed-ci
Copy link

mbed-ci commented Apr 11, 2018

@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Apr 11, 2018

@adbridge I did not remove the header. Directly from the comment in the pull request template:

Please tick only one of the following types. Do not tick more or change the layout.

I'm only following directions :P

This is yet another PR that's so simple, it can be described in the title, so the description element is superfluous.

@adbridge
Copy link
Contributor

@theotherjimmy I put the header back! It was missing both the '#Description' and the '#Pull request type' headers. So something or someone removed them on submission....

@0xc0170 Jimmy has a point about the semantics of the wording in the PR header wrt 'please tick one of the following'. Should probably say please add a 'x' to one of the following types to be specific....

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2018

@0xc0170 Jimmy has a point about the semantics of the wording in the PR header wrt 'please tick one of the following'. Should probably say please add a 'x' to one of the following types to be specific....

Will fix

@theotherjimmy
Copy link
Contributor Author

@adbridge I may have forgotten to add a space before them on submission, then the would have been stripped from the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants