-
Notifications
You must be signed in to change notification settings - Fork 3k
Error on invalid mbed_lib JSON #6552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph build |
Build : SUCCESSBuild number : 1671 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1304 |
@theotherjimmy The proforma for this PR has been modified again! This will break our automation script once it goes live. Please do not remove the 'Description' or 'Pull request type' headers and please use a 'X' in the checkbox rather than a tick! |
Exporter Build : FAILUREBuild number : 1354 |
@adbridge I did not remove the header. Directly from the comment in the pull request template:
I'm only following directions :P This is yet another PR that's so simple, it can be described in the title, so the description element is superfluous. |
@theotherjimmy I put the header back! It was missing both the '#Description' and the '#Pull request type' headers. So something or someone removed them on submission.... @0xc0170 Jimmy has a point about the semantics of the wording in the PR header wrt 'please tick one of the following'. Should probably say please add a 'x' to one of the following types to be specific.... |
Will fix |
@adbridge I may have forgotten to add a space before them on submission, then the would have been stripped from the PR description. |
Description
Resolves #5908
Pull request type
[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change