-
Notifications
You must be signed in to change notification settings - Fork 3k
[MAX32620C] Add new target #6503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@khariya, could you share the test results for all three compilers with this new target? Also, please take a look at the Travis CI docs failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question regarding deepsleep, the rest looks good to me
// Low-power stop mode | ||
void hal_deepsleep(void) | ||
{ | ||
hal_sleep(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why deep sleep = sleep ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current DAPLink implementation unable to wake device from deep sleep (Maxim LP1) for reprogramming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a pity, is this limitation captured anywhere? If you look at feature hal specs for sleep (there's feature branch for it), this will cause a failure there with this new specifications.
Will this be fixed later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deep sleep feature is implemented but not released. We are working to add "connect under reset" functionality to the DAPLink drag and drop interface.
Test results for MAX32620FTHR on all 3 compilers: |
/morph build |
Build : SUCCESSBuild number : 1665 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1299 |
/morph mbed2-build |
[MAX32620C] Add new target
Description
Add new target MAX32620C with MAX32620FTHR platform.
Tested all supported toolchains with MAX32620FTHR.
Pull request type
[ ] Fix
[ ] Refactor
[X] New target
[ ] Feature
[ ] Breaking change