Skip to content

[MAX32620C] Add new target #6503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Apr 9, 2018
Merged

[MAX32620C] Add new target #6503

merged 2 commits into from Apr 9, 2018

Conversation

khariya
Copy link
Contributor

@khariya khariya commented Mar 28, 2018

[MAX32620C] Add new target

Description

Add new target MAX32620C with MAX32620FTHR platform.

Tested all supported toolchains with MAX32620FTHR.

Pull request type

[ ] Fix
[ ] Refactor
[X] New target
[ ] Feature
[ ] Breaking change

@cmonr
Copy link
Contributor

cmonr commented Apr 3, 2018

@khariya, could you share the test results for all three compilers with this new target?

Also, please take a look at the Travis CI docs failure.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question regarding deepsleep, the rest looks good to me

// Low-power stop mode
void hal_deepsleep(void)
{
hal_sleep();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why deep sleep = sleep ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current DAPLink implementation unable to wake device from deep sleep (Maxim LP1) for reprogramming.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a pity, is this limitation captured anywhere? If you look at feature hal specs for sleep (there's feature branch for it), this will cause a failure there with this new specifications.

Will this be fixed later?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deep sleep feature is implemented but not released. We are working to add "connect under reset" functionality to the DAPLink drag and drop interface.

@khariya
Copy link
Contributor Author

khariya commented Apr 4, 2018

Test results for MAX32620FTHR on all 3 compilers:
mbed_test_max32620fthr_arm.txt
mbed_test_max32620fthr_gcc-arm.txt
mbed_test_max32620fthr_iar.txt

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 5, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 5, 2018

Build : SUCCESS

Build number : 1665
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6503/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 5, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 5, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 6, 2018

/morph mbed2-build

@0xc0170 0xc0170 merged commit 1b2f63a into ARMmbed:master Apr 9, 2018
@khariya khariya deleted the add-platform-MAX32620C branch April 9, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants