Skip to content

ADI: Fix EV_COG_AD3029LZ and EV_COG_AD4050LZ us_ticker_fire_interrupt() minimal time interval #6490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2018
Merged

ADI: Fix EV_COG_AD3029LZ and EV_COG_AD4050LZ us_ticker_fire_interrupt() minimal time interval #6490

merged 2 commits into from
Apr 6, 2018

Conversation

li-ho
Copy link

@li-ho li-ho commented Mar 27, 2018

Description

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

Steps to reproduce

mbed test -m EV_COG_AD3029LZ -t GCC_ARM -n mbed-os-tests-mbed_drivers-timerevent,mbed-os-tests-mbed_platform-critical_section
mbed test -m EV_COG_AD4050LZ -t GCC_ARM -n mbed-os-tests-mbed_drivers-timerevent,mbed-os-tests-mbed_platform-critical_section

@li-ho
Copy link
Author

li-ho commented Mar 28, 2018

mbedgt: test suite report:
+-----------------------+-----------------+--------------------------------------------------------------------------------------+--------+--------------------+-------------+
| target                | platform_name   | test suite                                                                           | result | elapsed_time (sec) | copy_method |
+-----------------------+-----------------+--------------------------------------------------------------------------------------+--------+--------------------+-------------+
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-frameworks-utest-tests-unit_tests-basic_test                        | OK     | 14.99              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-frameworks-utest-tests-unit_tests-basic_test_default                | OK     | 15.2               | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-frameworks-utest-tests-unit_tests-case_async_validate               | OK     | 17.09              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-frameworks-utest-tests-unit_tests-case_control_async                | OK     | 23.65              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-frameworks-utest-tests-unit_tests-case_control_repeat               | OK     | 17.22              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-frameworks-utest-tests-unit_tests-case_selection                    | OK     | 15.0               | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-frameworks-utest-tests-unit_tests-case_setup_failure                | OK     | 15.47              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-frameworks-utest-tests-unit_tests-case_teardown_failure             | OK     | 15.65              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-frameworks-utest-tests-unit_tests-control_type                      | OK     | 16.35              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-frameworks-utest-tests-unit_tests-minimal_async_scheduler           | OK     | 16.09              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-frameworks-utest-tests-unit_tests-minimal_scheduler                 | OK     | 16.56              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-frameworks-utest-tests-unit_tests-test_assertion_failure_test_setup | OK     | 14.72              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-frameworks-utest-tests-unit_tests-test_setup_case_selection_failure | OK     | 14.82              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-frameworks-utest-tests-unit_tests-test_setup_failure                | OK     | 14.85              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-nvstore-tests-nvstore-functionality                                 | OK     | 24.8               | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-tests-filesystem-heap_block_device                                  | OK     | 17.35              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-tests-filesystem-mbr_block_device                                   | OK     | 16.19              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-features-tests-filesystem-util_block_device                                  | OK     | 15.79              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-events-queue                                                           | OK     | 23.42              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-events-timing                                                          | OK     | 75.77              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-integration-basic                                                      | OK     | 13.53              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_drivers-c_strings                                                 | OK     | 17.02              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_drivers-dev_null                                                  | OK     | 15.74              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_drivers-echo                                                      | OK     | 16.51              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_drivers-flashiap                                                  | OK     | 15.94              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_drivers-generic_tests                                             | OK     | 15.1               | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_drivers-race_test                                                 | OK     | 15.91              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_drivers-rtc                                                       | OK     | 30.64              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_drivers-sleep_lock                                                | OK     | 14.95              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_drivers-stl_features                                              | OK     | 16.06              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_drivers-ticker                                                    | OK     | 42.16              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_drivers-timeout                                                   | OK     | 54.66              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_drivers-timer                                                     | OK     | 23.46              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_drivers-timerevent                                                | OK     | 17.11              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_functional-callback                                               | OK     | 16.77              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_functional-callback_big                                           | OK     | 16.64              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_functional-callback_small                                         | OK     | 16.44              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_functional-functionpointer                                        | OK     | 14.99              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-critical_section                                              | OK     | 15.27              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-flash                                                         | OK     | 19.53              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-lp_us_tickers                                                 | OK     | 15.22              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc_time                                                      | OK     | 17.1               | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc_time_conv                                                 | OK     | 33.73              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-sleep_manager                                                 | OK     | 14.56              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-sleep_manager_racecondition                                   | OK     | 27.93              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-ticker                                                        | OK     | 30.66              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_platform-critical_section                                         | OK     | 17.01              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_platform-filehandle                                               | OK     | 16.54              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_platform-singletonptr                                             | OK     | 14.87              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_platform-system_reset                                             | OK     | 15.01              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbed_platform-transaction                                              | OK     | 15.67              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-mbed-attributes                                              | OK     | 16.88              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-mbed-call_before_main                                        | OK     | 13.56              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-mbed-cpp                                                     | OK     | 13.74              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-mbed-div                                                     | OK     | 13.63              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-mbed-static_assert                                           | OK     | 14.45              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-rtos-mbed-basic                                              | OK     | 24.1               | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-rtos-mbed-circularbuffer                                     | OK     | 22.34              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-rtos-mbed-condition_variable                                 | OK     | 15.4               | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-rtos-mbed-event_flags                                        | OK     | 18.35              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-rtos-mbed-heap_and_stack                                     | OK     | 15.61              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-rtos-mbed-mail                                               | OK     | 21.04              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-rtos-mbed-malloc                                             | OK     | 35.81              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-rtos-mbed-memorypool                                         | OK     | 23.42              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-rtos-mbed-mutex                                              | OK     | 19.79              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-rtos-mbed-queue                                              | OK     | 18.73              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-rtos-mbed-rtostimer                                          | OK     | 18.14              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-rtos-mbed-semaphore                                          | OK     | 20.03              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-rtos-mbed-signals                                            | OK     | 22.45              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedmicro-rtos-mbed-threads                                            | OK     | 28.46              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedtls-multi                                                          | OK     | 16.42              | default     |
| EV_COG_AD3029LZ-ARMC6 | EV_COG_AD3029LZ | mbed-os-tests-mbedtls-selftest                                                       | OK     | 27.73              | default     |
+-----------------------+-----------------+--------------------------------------------------------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 72 OK

@theotherjimmy
Copy link
Contributor

@li-ho It looks like the 2 commits in this history are duplicates of each other. They seem to make distinct changes. Could you update their titles to reflect the changes they make? Let me know if you would like help doing that.

@li-ho li-ho changed the title ADI: Fix EV_COG_ADxxxxLZ us_ticker_fire_interrupt() minimal time interval ADI: Fix EV_COG_AD3029LZ and EV_COG_AD4050LZ us_ticker_fire_interrupt() minimal time interval Mar 29, 2018
@li-ho
Copy link
Author

li-ho commented Mar 29, 2018

@theotherjimmy
This PR is a bug fix to 2 boards.
It's the same change to 2 targets, and these 2 files are located in different folders.
Please review.

Edmund Hsu added 2 commits April 1, 2018 19:34
- ensure us_ticker_irq_handler() is called only when GP2 timer expires
- set us_ticker_set_interrupt() time interval to be 9.846 us
- set us_ticker_fire_interrupt() time interval to be 0.03846 us
- convert tab to space
- ensure us_ticker_irq_handler() is called only when GP2 timer expires
- set us_ticker_set_interrupt() time interval to be 9.846 us
- set us_ticker_fire_interrupt() time interval to be 0.03846 us
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2018

Build : SUCCESS

Build number : 1642
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6490/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2018

@0xc0170 0xc0170 merged commit 54b6aa3 into ARMmbed:master Apr 6, 2018
@li-ho li-ho deleted the ev-cog-us-ticker-fire-interrupt branch April 12, 2018 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants