Skip to content

Cellular: add callback API #6329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Mar 15, 2018
Merged

Cellular: add callback API #6329

merged 1 commit into from Mar 15, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 12, 2018

Description

Network connection status callback API added

Pull request type

  • Fix

@ghost
Copy link
Author

ghost commented Mar 12, 2018

@AnttiKauppila @juhoeskeli please review

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 12, 2018

/morph build

@0xc0170 0xc0170 changed the title callback API added Cellular: add callback API Mar 12, 2018
@AnttiKauppila
Copy link

Even if this looks like an API change it is not. AT_CellularNetwork already implements these functions, and these functions are inherited from NetworkInterface. CellularNetwork is between of these classes and should inherit same functions.

@mbed-ci
Copy link

mbed-ci commented Mar 12, 2018

Build : SUCCESS

Build number : 1414
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6329/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 12, 2018

Even if this looks like an API change it is not. AT_CellularNetwork already implements these functions, and these functions are inherited from NetworkInterface. CellularNetwork is between of these classes and should inherit same functions.

This means this is a fix, not a feature as stated above

@mbed-ci
Copy link

mbed-ci commented Mar 12, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 12, 2018

@cmonr cmonr merged commit 92bbdbb into ARMmbed:master Mar 15, 2018
@ghost ghost deleted the callback_changes branch July 11, 2018 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants