Skip to content

rtl8195am : fix gpio toggle slow #6326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2018

Conversation

M-ichae-l
Copy link
Contributor

Description

Ameba has two memory blocks: SDRAM(2M) and SRAM(512KB). SRAM has better access performance than SDRAM. So some timing critical codes must be moved to SRAM.

fix for mbed-os issue #5778

rebase for #6289

Pull request type

  • Fix

Ameba has two memory blocks: SDRAM(2M) and SRAM(512KB). SRAM has better access performance than SDRAM. So some timing critical codes must be moved to SRAM.

fix for mbed-os issue ARMmbed#5778

rebase for ARMmbed#6289
@M-ichae-l M-ichae-l mentioned this pull request Mar 12, 2018
5 tasks
0xc0170
0xc0170 previously approved these changes Mar 12, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 12, 2018

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 12, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 12, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 12, 2018

@M-ichae-l Can you please review the failure

@M-ichae-l
Copy link
Contributor Author

Hi,
I have passed the local build. Please refer to the log and give some suggestions? Thank you.

log_GPIO_toggle.txt

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 13, 2018

Please follow the above link (http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6326/) where you can review the logs. The test that fails to build for ARMCC is a transaction test.

mbed test -m REALTEK_RTL8195AM -t ARM -n tests-mbed_platform-transaction --compile - this command should reproduce the failure locally

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2018

* 20b33637f - (HEAD -> M-ichae-l-rtl8195am-gpio-toggle-slow-fix) rtl8195am : fix gpio toggle slow (2 days ago) <zzw>
*   f67fe4a7a - (upstream/master, upstream/feature-hal-spec-sai, master, feature-hal-spec-sai) Merge pull request #6257 from SenRamakri/sen_FaultHandlerFixes (6 days ago) <Jimmy Brisson>
|\
| * 72f45b83e - Add mode and privilege info to crash dump (8 days ago) <Senthil Ramakrishnan>
| * 06f5fbc75 - Fix linefeed issues in crash dump output (8 days ago) <Senthil Ramakrishnan>
* |   cf4c7a5d3 - Merge pull request #6164 from ashok-rao/br-BL652 (6 days ago) <Martin Kojtal>
|\ \
| * | 008e93752 - Incorporating review comments (8 days ago) <Ashok Rao>
| * | 65f210288 - Adding Laird BL652 as new target (3 weeks ago) <Ashok Rao>
* | |   d2f00a054 - Merge pull request #6171 from anttiylitokola/master (6 days ago) <Martin Kojtal>
|\ \ \
| * | | 1b27317e6 - Update mbed-coap to version 4.3.0 (3 weeks ago) <Antti Yli-Tokola>
* | | |   4e7ad0dc9 - Merge pull request #6226 from M-ichae-l/mbed-os_ci-test-fixed_rtl8195am (6 days ago) <Martin Kojtal>
|\ \ \ \

mbed test -m REALTEK_RTL8195AM -t ARM -n tests-mbed_platform-transaction --compile

Build successes:
  * REALTEK_RTL8195AM::ARM::MBED-BUILD


Build failures:
  * REALTEK_RTL8195AM::ARM::TESTS-MBED_PLATFORM-TRANSACTION
        Building project Transaction (REALTEK_RTL8195AM, ARM)
        Scan: ARM
        Scan: Transaction
        Scan: FEATURE_LWIP
        Compile [100.0%]: main.cpp
        Link: Transaction
        Error: L6216E: Cannot use base/limit symbols for non-contiguous section .init_array
        Error: L6216E: Cannot use base/limit symbols for non-contiguous section .init_array
        Finished: 0 information, 0 warning and 2 error messages.

I pasted here git log (I branched from master as of today and fetched your branch). Run the command and reproduced the same errors. My armcc is ARM Compiler 5.06 update 5 (build 528)

@M-ichae-l
Copy link
Contributor Author

Thank you very much.
Please let me to review the failure.

fix mbed-ci build  error L6216E
* (.ARM.exidx) and *(.init_array) must be placed explicitly, otherwise it is shared between two regions, and the linker is unable to decide where to place it.
@M-ichae-l
Copy link
Contributor Author

I have update a new commit to fix the Error: L6216E.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 15, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 15, 2018

Build : SUCCESS

Build number : 1455
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6326/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 15, 2018

@cmonr
Copy link
Contributor

cmonr commented Mar 15, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 16, 2018

/morph mbed2-build

@cmonr cmonr merged commit 1aa78d1 into ARMmbed:master Mar 16, 2018
@M-ichae-l M-ichae-l deleted the rtl8195am-gpio-toggle-slow-fix branch March 21, 2018 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants