Skip to content

MCUXpresso: Fix test failures seen with ci-test shield #6310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2018

Conversation

mmahadevan108
Copy link
Contributor

@mmahadevan108 mmahadevan108 commented Mar 8, 2018

A. Enable internal pullup resistor for sda and scl lines.
B. Update the implmentation for byte read and write

  1. Start function: Issue repeat start when bus is busy
  2. Byte write function: Do not call SDK function as this does
    not work for some of the Kinetis device
  3. Byte read function: Do not call SDK function as this would
    issue a START and STOP signal which is not required for
    I2C byte functions
    C. Fix K82F I2C ci-test shield failure

Ran the I2C ci-test shield tests to confirm

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

@mmahadevan108
Copy link
Contributor Author

cc @maclobdell @0xc0170

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 9, 2018

@mmahadevan108 👍 Thanks for fixes

Looking at the changes, should A-C be separate commits? From the code changes and the description I would say yes, to separate these 3 fixes, and address each one in the own commit

Please use pull request type section in the pull request , this info is required. I updated it to add it back there.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be 3 separate commits addressing each issue in this PR

I2C3 clock define was missing. I2C3 is connected to the Arduino
connector which is used by the ci-test shield

Signed-off-by: Mahesh Mahadevan <[email protected]>
1. Start function: Issue repeat start when bus is busy
2. Byte write function: Do not call SDK function as this does
   not work for some of the Kinetis device
3. Byte read function: Do not call SDK function as this would
   issue a START and STOP signal which is not required for
   I2C byte functions

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108
Copy link
Contributor Author

@0xc0170. Thanks for the suggestion, I have split this into 3 commits.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 9, 2018

Build : SUCCESS

Build number : 1402
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6310/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 9, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 9, 2018

@cmonr cmonr merged commit 842a86a into ARMmbed:master Mar 15, 2018
@mmahadevan108 mmahadevan108 deleted the Fix_K82F_I2C branch March 19, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants