-
Notifications
You must be signed in to change notification settings - Fork 3k
MCUXpresso: Fix test failures seen with ci-test shield #6310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mmahadevan108 👍 Thanks for fixes Looking at the changes, should A-C be separate commits? From the code changes and the description I would say yes, to separate these 3 fixes, and address each one in the own commit Please use pull request type section in the pull request , this info is required. I updated it to add it back there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be 3 separate commits addressing each issue in this PR
I2C3 clock define was missing. I2C3 is connected to the Arduino connector which is used by the ci-test shield Signed-off-by: Mahesh Mahadevan <[email protected]>
Signed-off-by: Mahesh Mahadevan <[email protected]>
1. Start function: Issue repeat start when bus is busy 2. Byte write function: Do not call SDK function as this does not work for some of the Kinetis device 3. Byte read function: Do not call SDK function as this would issue a START and STOP signal which is not required for I2C byte functions Signed-off-by: Mahesh Mahadevan <[email protected]>
c097bfd
to
5230bca
Compare
@0xc0170. Thanks for the suggestion, I have split this into 3 commits. |
/morph build |
Build : SUCCESSBuild number : 1402 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1054 |
A. Enable internal pullup resistor for sda and scl lines.
B. Update the implmentation for byte read and write
not work for some of the Kinetis device
issue a START and STOP signal which is not required for
I2C byte functions
C. Fix K82F I2C ci-test shield failure
Ran the I2C ci-test shield tests to confirm
Pull request type