Clarify intention between comparison to zero and the shift operation #6263
Conversation
Building with (GNU Tools for Arm Embedded Processors 7-2017-q4-major) 7.2.1 20170904 gives this warning
../events/equeue/equeue.c: In function 'equeue_incid':
../events/equeue/equeue.c:40:17: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context]
if (!(e->id << q->npw2)) {
|
@pauluap Thanks for the fix. Can you please sign https://os.mbed.com/contributor_agreement/ ? Please use the github template to specify what type of PR is it (I updated it for now) |
|
I clicked "accept" on the contributor agreement link, not sure if you get notified of that |
events/equeue/equeue.c
Outdated
| @@ -37,7 +37,7 @@ static inline int equeue_clampdiff(unsigned a, unsigned b) { | |||
| // Increment the unique id in an event, hiding the event from cancel | |||
| static inline void equeue_incid(equeue_t *q, struct equeue_event *e) { | |||
| e->id += 1; | |||
| if (!(e->id << q->npw2)) { | |||
| if (0 == (e->id << q->npw2)) { | |||
There was a problem hiding this comment.
nit: Could you flip the order of this comparison? It's easier to read with constants on the right, and all of our compilers have warnings against asignments in if statements anyways.
|
/morph build |
Build : SUCCESSBuild number : 1356 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1009 |
|
/morph mbed2-build |
Description
Building with (GNU Tools for Arm Embedded Processors 7-2017-q4-major) 7.2.1 20170904 gives this warning
../events/equeue/equeue.c: In function 'equeue_incid':
../events/equeue/equeue.c:40:17: warning: '<<' in boolean context, did you mean '<' ? [-Wint-in-bool-context]
if (!(e->id << q->npw2)) {
Pull request type