Skip to content

Build issue for M33 core #6214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Build issue for M33 core #6214

merged 1 commit into from
Feb 28, 2018

Conversation

tkaman
Copy link
Contributor

@tkaman tkaman commented Feb 26, 2018

Fix typo in irq_armv8mml.S

Signed-off-by: Tamas Kaman [email protected]

Description

Because of this typo building this assembly file failed

For testing I simply run the build again and the build error was gone.

Pull request type

  • Fix

Fix typo in irq_armv8mml.S

Signed-off-by: Tamas Kaman <[email protected]>
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is GitHub's online diff tool acting weird, but is the only difference a + at the beginning of the line?

Copy link

@deepikabhavnani deepikabhavnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2018

/morph build

@deepikabhavnani
Copy link

Maybe this is GitHub's online diff tool acting weird, but is the only difference a + at the beginning of the line?

Yes this + went in somehow

@deepikabhavnani
Copy link

@cmonr - Can you try restarting the failing CI job?

@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2018

@deepikabhavnani Unfortunately I don't think I'm able to restart continuous-integration/jenkins/pr-head remotely. Will be looking into it first thing tomorrow assuming it's still an issue then.

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Build : SUCCESS

Build number : 1267
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6214/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2018

Simply noting for the PR's history, pr-head is still experiencing issues...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants