RTX5: Pre-processor defines used for assembly #6029
Conversation
CMSIS repo does not support pre-processor defines, hence multiple assembly files are added for secure/non-secure and floating point tools. Mbed OS tools support assembly file pre-processing, but the build system does not support multiple assembly files for each target, hence updating the assembly files.
| @@ -1,3 +0,0 @@ | |||
| .equ __FPU_USED, 1 | |||
There was a problem hiding this comment.
we do not need these removed files at all?
There was a problem hiding this comment.
No, we don’t need them. We can add FPU and other defines from tools, based on core selected or using -D option
There was a problem hiding this comment.
Let's not use -D if we can avoid it.
There was a problem hiding this comment.
Ideally FPU and DSP selection should be supported from tools, agree to that.
|
/morph build |
Build : SUCCESSBuild number : 1085 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 762 |
|
These changes will not be accepted by CMSIS repo as per my knowledge. Its same as cortex 4/7 processor where we have FPU defines and code is not same as CMSIS |
|
@bulislaw - We need ARM-software/CMSIS_5@05fa9d3#diff-87a9bb8eedc11ec34f4697a894983dd4 changes from CMSIS for M23, do we have any plans to update CMSIS/RTX code in mbed-os |
Systick handler switch to secure/nonsecure issues addressed: 1. Switch to secure/nonsecure context save/restore is based on 6th bit in LR register, correct the bug (R7 instead of LR was used for decision) 2. Prevent R7 from being corrupted in Sys_ContextSave 3. Branch when non-secure rather than secure
We will need to get rid of all changes to CMSIS/RTX soon to support cmsis-pack. |
|
What are you asking exactly? Until the build system can build a cmsis-pack directly, we need to have some modifications to the CMSIS_5 repo to make it build with our build system. |
|
@deepikabhavnani shall we add patches to our update script config file? |
|
@bulislaw - Update the json file with SHA for this fix |
|
/morph build |
Build : SUCCESSBuild number : 1132 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 809 |
CMSIS repo does not support pre-processor defines, hence multiple assembly files are added for secure/non-secure and floating point tools.
Mbed OS tools support assembly file pre-processing, but the build system does not support multiple assembly files for each target, hence updating the assembly files.
@0xc0170 @bulislaw
Once this PR is merged to the master, SHA should be recorded in
cmsis_importer.jsonscript so that files are not over-written in next CMSIS update.