Correct memap path handling on windows #5775
Conversation
Parsing dispatch now uses a metaclass as a Trait and a series of classes that implement the trait for dispatching parsing. This structure gives each parser it's own namespace, avoiding tacking on suffixes to each attribute indicating which parser uses it.
|
/morph build |
Build : SUCCESSBuild number : 792 Triggering tests/morph test |
|
|
||
| for i in self.all_sections: | ||
| return value - A section name, if a new section was found, False |
There was a problem hiding this comment.
I know you didn't add this function per se but it seems like bad programming practice to have different return types for the same return variable. E.g. Returning False implies a Boolean return type but returning a value implies something else....
There was a problem hiding this comment.
This is so extremely common in python, just with None instead of False
|
|
||
| return '[lib]/' + object_name | ||
|
|
||
| return join('[lib]', test_re_obj_name.group(2), |
There was a problem hiding this comment.
Might be good to have a comment saying what group(2) and (3) actually are ?
There was a problem hiding this comment.
I can add that.
Exporter Build : SUCCESSBuild number : 446 |
Includes a parser refactor, as I got a bit irritated by seeing
_gccsuffixed method names.
Resolves #5772
Todo