Fix bug for issue: initial pin value not retained #5487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For api usage like DigitalOut led(LED1, 1) the hal function gpio_write() sets the output before f. gpio_mode() is called. gpio_mode() clears the output as it take never writen parameters (gpio_cfg_t.init_hight). This patch use internal hardware register of GPIO output instedad of above paramiter latch for retaining proper writen state.
0xc0170
approved these changes
Nov 14, 2017
|
/morph build |
Build : SUCCESSBuild number : 516 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 131 |
|
/morph test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For api usage like DigitalOut led(LED1, 1) the hal function gpio_write()
sets the output before f. gpio_mode() is called. gpio_mode() clears the
output as it take never writen parameters (gpio_cfg_t.init_hight).
This patch use internal hardware register of GPIO output instedad of above paramiter latch
for retaining proper writen state.
Fix for #5462 (comment)