Skip to content

event queue test: fix out of memory for NUCLEO_F070RB #5370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2017
Merged

event queue test: fix out of memory for NUCLEO_F070RB #5370

merged 1 commit into from
Nov 9, 2017

Conversation

maciejbocianski
Copy link
Contributor

Description

Reduce memory consumption to make it "passed" on NUCLEO_F070RB + GCC_ARM compiler

Status

READY

Migrations

NO

0xc0170
0xc0170 reviewed Oct 24, 2017
View reviewed changes
TESTS/events/queue/main.cpp Outdated
@@ -22,7 +22,7 @@

using namespace utest::v1;

#define TEST_EQUEUE_SIZE 1024
#define TEST_EQUEUE_SIZE (18*EVENTS_EVENT_SIZE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am not familiar with event_size, why this is 18 ? The commit neither any code/comment here provides that information how this number was selected

Copy link
Contributor Author

@maciejbocianski maciejbocianski Oct 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bulislaw
There is no strict answer.
1024 was to large to make a test passed on NUCLEO_F070RB + GCC_ARM compiler so the value was reduced below 1024.
I thought it will be more readable if expressed in EVENTS_EVENT_SIZE
same as is in EventQueue constructor

/** EVENTS_QUEUE_SIZE
 *  Default size of buffer for events
 */
#define EVENTS_QUEUE_SIZE (32*EVENTS_EVENT_SIZE)

EventQueue(unsigned size=EVENTS_QUEUE_SIZE, unsigned char *buffer=NULL);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK that explains it, we are testing maximum of 18 events.

What I was after that this is a fix, and commit does not explain how it is fixing the issue (reducing event queue size to 18 events, as test does not require more, or something similar).

@bulislaw
Copy link
Member

@maciejbocianski can you please add a comment explaining why we use 18.

@jeromecoutant
Copy link
Collaborator

OK !

| NUCLEO_F070RB-GCC_ARM | NUCLEO_F070RB | tests-events-queue | OK | 22.29 | default |
| NUCLEO_F072RB-GCC_ARM | NUCLEO_F072RB | tests-events-queue | OK | 22.42 | default |
| NUCLEO_L073RZ-GCC_ARM | NUCLEO_L073RZ | tests-events-queue | OK | 25.51 | default |

@adbridge
Copy link
Contributor

@maciejbocianski Could you please address the comments ?

@maciejbocianski
Copy link
Contributor Author

@bulislaw description added

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 3, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 3, 2017

Build : SUCCESS

Build number : 421
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5370/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Nov 3, 2017

Test : FAILURE

Build number : 212
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5370/212

@maciejbocianski
Copy link
Contributor Author

Many tests failed on K64F with following error:

SYNC_FAILED - 0% (0/1)

[1509722436.96][CONN][INF] resending new preamble '031d0a56-2114-456d-aba8-5329e5353e4f' after 5.00 sec 
[1509722436.96][GLRM][TXD] {{__sync;031d0a56-2114-456d-aba8-5329e5353e4f}} 
[1509722436.96][CONN][INF] output : and error : Unknown device, --name=, --path=, or absolute path in /dev/ or /sys expected. 
[1509722436.97][urllib3.connectionpool]Starting new HTTP connection (1): austin-ci-linux-001.austin.arm.com 
[1509722437.08][urllib3.connectionpool]http://austin-ci-linux-001.austin.arm.com:8000 "PUT /resource/0240000031754e45000c0018948500156461000097969900/disconnect HTTP/1.1" 200 2 
[1509722437.08][urllib3.connectionpool]Starting new HTTP connection (1): austin-ci-linux-001.austin.arm.com 
[1509722439.25][urllib3.connectionpool]http://austin-ci-linux-001.austin.arm.com:8000 "PUT /resource/0240000031754e45000c0018948500156461000097969900/release HTTP/1.1" 200 66 
[1509722439.25][HTST][ERR] None 
[1509722439.25][HTST][WRN] stopped to consume events due to __notify_sync_failed event 
[1509722439.25][HTST][INF] __exit_event_queue received 
[1509722439.25][HTST][INF] test suite run finished after 70.24 sec... 
[1509722439.25][HTST][INF] CONN exited with code: 0 
[1509722439.25][HTST][INF] No events in queue 
[1509722439.25][HTST][INF] host test result() call skipped, received: sync_failed 
[1509722439.25][HTST][WRN] missing __exit event from DUT 
[1509722439.25][HTST][INF] calling blocking teardown() 
[1509722439.25][HTST][INF] teardown() finished 
[1509722439.25][HTST][INF] {{result;sync_failed}}

@mbed-ci
Copy link

mbed-ci commented Nov 6, 2017

Build : SUCCESS

Build number : 437
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5370/

Triggering tests

/morph test
/morph uvisor-test

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 6, 2017

@maciejbocianski Thanks for the info. I noticed another job with the same failures, something probably happend to K64F target on Friday, I am waiting for one current test to see if it persists or not.

cc @studavekar for visibility

@mbed-ci
Copy link

mbed-ci commented Nov 6, 2017

Test : FAILURE

Build number : 245
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5370/245

@studavekar
Copy link
Contributor

/morph test

@mbed-ci
Copy link

mbed-ci commented Nov 7, 2017

Test : FAILURE

Build number : 263
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5370/263

@mbed-ci
Copy link

mbed-ci commented Nov 7, 2017

Test : FAILURE

Build number : 264
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5370/264

@mbed-ci
Copy link

mbed-ci commented Nov 7, 2017

Test : SUCCESS

Build number : 267
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5370/267

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 8, 2017

One more run to be certain

/morph test

@mbed-ci
Copy link

mbed-ci commented Nov 8, 2017

Test : SUCCESS

Build number : 276
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5370/276

@0xc0170 0xc0170 changed the title event queue test: fix out of memory problem for NUCLEO_F070RB event queue test: fix out of memory for NUCLEO_F070RB Nov 9, 2017
@0xc0170 0xc0170 merged commit 6713513 into ARMmbed:master Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.6.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@maciejbocianski @bulislaw @jeromecoutant @adbridge @0xc0170 @mbed-ci @studavekar