Ble: generic event filter #5299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcbonnici @nvlsianpu @apalmieriGH Could you review this PR ? |
Build : SUCCESSBuild number : 125 Triggering tests/test mbed-os |
Merged
marcbonnici
reviewed
Oct 12, 2017
features/FEATURE_BLE/source/BLE.cpp
Outdated
| transport->processEvents(); | ||
| } | ||
|
|
||
| void BLE::onEventsToProcess(const BLE::OnEventsToProcessCallback_t& callback) | ||
| { | ||
| whenEventsToProcess = callback; | ||
|
|
||
| // If events where previously signaled but the handler was not in place then |
08b0c40 to
1286c98
Compare
1286c98 to
90897b4
Compare
|
@pan- any update? more work or ? |
|
None I'm aware of. That may help if it gets reviewed by others 😅 . |
This interface expose the primitives needed to realize operations defined in the GAP layer. Data types, event and function definitions follow closely HCI commands and events defined in the Bluetooth specification.
Add an abstraction which manage the state of the GAP service exposed by the GATT server.
This filter prevent events to be signaled multiple times to the upper layer. It also signal events to a newly set event processor hook.
90897b4 to
63668cb
Compare
|
@marcbonnici Can you review/approve this please? |
marcbonnici
approved these changes
Nov 14, 2017
nvlsianpu
approved these changes
Nov 15, 2017
|
/morph build |
Build : SUCCESSBuild number : 557 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This filter prevent events to be signaled multiple times to the upper layer. It
also signal events to a newly set event processor hook.
Previously filtering was made at the port level with that patch it is factored out at an higher level.
Status
READY
Migrations
BLE ports may be updated after this PR has been merged to benefit from the builtin filter. Note that existing code continue to work however it can be simplified.
Related PRs
#5296
Note
Diff can be found here: pan-/mbed@generic-access-service-abstraction-layer...pan-:ble-generic-event-filter