Skip to content

Fix MBED_ VERSION #5132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Fix MBED_ VERSION #5132

merged 1 commit into from
Sep 18, 2017

Conversation

JanneKiiskila
Copy link
Contributor

Remove the extraneous #define at the end of it.

Remove the extraneous #define at the end of it.
@adbridge
Copy link
Contributor

adbridge commented Sep 18, 2017

@JanneKiiskila Thanks for finding this, I'll check the automation script to see how that crept in (this bit of functionality was used for the first time with this release). We don't normally take PRs directly against the release branch but as this block only exists there we will need to on this occasion .

@adbridge
Copy link
Contributor

/morph test

@adbridge
Copy link
Contributor

Not sure why Travis failed , kicked it off again

@adbridge
Copy link
Contributor

/morph test

@adbridge
Copy link
Contributor

/morph echo

@studavekar
Copy link
Contributor

/morph test

@JanneKiiskila
Copy link
Contributor Author

Please get this to RC2. Personally, I would not even consider doing an RC2 without this.

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1327

Test failed!

@studavekar
Copy link
Contributor

Failure looks like device specific and not related to change


[1505754235.12][COPY][INF] Waiting for mount point 'J:' to be ready...

..............................[1505754242.84][COPY][ERR] mount J: is not accessible ...

[1505754246.84][COPY][INF] Waiting up to 60 sec for '0214000024404e4500493017ffff000fffffffff97969900' mount point (current is 'J:')...

[1505754475.36][COPY][INF] Waiting for mount point 'J:' to be ready...

..............................[1505754483.08][COPY][ERR] mount J: is not accessible ...

[1505754487.08][COPY][INF] Waiting up to 60 sec for '0214000024404e4500493017ffff000fffffffff97969900' mount point (current is 'J:')...

[1505754713.01][COPY][INF] Waiting for mount point 'J:' to be ready..

Re-triggering the request

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1335

All builds and test passed!

@theotherjimmy theotherjimmy merged commit 411b7fd into ARMmbed:mbed-os-5.6 Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants