MTS targets: Don't use any printf() calls when NDEBUG is defined #5013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vents linking out printf() and friends in release build
bulislaw
reviewed
Sep 4, 2017
|
@bulislaw Because in 2 files there's only one I'm open to suggestions though on how to make this more clean. |
|
Fair enough. I guess we should introduce some sort of mbed wide debug print wrappers (that don't require external lib) sooner rather than later. |
bulislaw
approved these changes
Sep 4, 2017
0xc0170
approved these changes
Sep 4, 2017
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
Why didn't this use the debug statement? https://github.com/ARMmbed/mbed-os/blob/master/platform/mbed_debug.h |
0xc0170
added a commit
to 0xc0170/mbed-os
that referenced
this pull request
Sep 6, 2017
Instead of using #if NDEBUG, we can directly invoke debug() function. Fixes ARMmbed#5013
adbridge
pushed a commit
that referenced
this pull request
Oct 6, 2017
Instead of using #if NDEBUG, we can directly invoke debug() function. Fixes #5013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior prevents linking out
printf()and friends in release builds. This patch makes blinky on xDot use 15K(!!!!) less flash when compiling release build with GCC_ARM./cc @chrissnow This pushes my bootloader for xDot to 22K on GCC, 21K on ARMCC.
@reissjason @sg-