Reduce K64F Ethernet driver to 1 thread #4996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
507dff9 to
34634f1
Compare
Save 1K of RAM by using only 1 thread for RX and TX, and running the PHY check in lwIP's context.
34634f1 to
65639e8
Compare
|
Looks good to me. |
0xc0170
approved these changes
Sep 4, 2017
|
/morph test-nightly |
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save 1K of RAM by using only 1 thread for RX and TX, and running the PHY check in lwIP's context.
This makes the driver function more a bit more like the Nanostack one in https://github.com/ARMmbed/sal-nanostack-driver-k64f-eth, and could be viewed as a first step towards unification as an EMAC driver.