Add flush to the BLE UART Service #4990
Conversation
If only buffer-full events and LF characters trigger the flush of the send buffer then only line-based communication can be implemented over the BLE UART Service. This patch extends the service API by adding an explicit `flush` method to force sending the buffer contents, thus enabling protocols with short (e.g., single character) messages.
|
@pan- please review |
|
@pan- Bump |
|
Bump for review @pan- |
|
Is there any way I can help the progress of this PR? |
|
Is there anything else I should/could do? |
|
Thanks for the ping @akosthekiss. We're currently working on a release, so testing may be delayed by a few days. In the mean time I have marked this as in the "testing" phase of a PR. We should get to testing many things in the needs: CI category, and merge them, shortly after the release. |
|
Thanks for the update! |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
@theotherjimmy Could these tests be re-executed somehow, perhaps? I don't know what could have failed. |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
I'm a bit puzzled. In mbed Build Number 1358, the MAX32630FTHR/GCC_ARM target failed, while in Build 1378, it was the ARM-BEETLE-SOC/GCC_ARM. It was 3 tests that timed out in both runs: tests-mbedmicro-rtos-{queue,isr,signals}. Is this some kind of flakyness of the test suite? |
|
@0xc0170 @theotherjimmy @pan- May I ask some help on this? (I mean, on the strange timeouts.) |
Maybe, or an issue in the CI. Those failures are not related to the PR. |
|
/morph test |
1 similar comment
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
If only buffer-full events and LF characters trigger the flush of
the send buffer then only line-based communication can be
implemented over the BLE UART Service. This patch extends the
service API by adding an explicit
flushmethod to force sendingthe buffer contents, thus enabling protocols with short (e.g.,
single character) messages.
Status
READY
Migrations
NO