mbedtls: STM32F439xI: Don't enable AES acceleration by default #4934
Conversation
STM32F439xI-family AES hardware acceleration occasionally produces incorrect output (ARMmbed#4928). Don't enable AES HW acceleration on STM32F439xI-family targets by default until issue ARMmbed#4928 is fixed.
|
Hello @Patater |
|
Hi @adustm The workaround implemented by @andresag01 yesterday was only for the Mbed TLS example. The issue is currently affecting all applications using AES on STM32F439xI-family targets. I would much prefer issue #4928 fixed instead of this PR's workaround merged. Please keep us posted. We'll watch the issue. Thanks |
|
Are you aware of any other use case that would fail ? |
|
@adustm |
|
@adustm: As @Patater mentioned, we do not have any other test cases that reproduce this issue. However, @JanneKiiskila mentioned:
If this is indeed some timing or concurrency issue, you could try to reproduce the problem by exercising the accelerator in a therad and while simultaneously spinning other threads that use IO such as ethernet or the sd card. Again, I am not sure this will reproduce the issue, but if it does its probably simpler to investigate than running the full TLS stack. |
|
/morph test |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
OutputExample Prep failed! |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
@yanesca Could you review when you get the chance? |
|
As this was approved by both sides, this run CI and be ready for integration (if the fix does not come by then). |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Critical workaround to issue #4928. This issue blocks releases until either the issue is fixed or this workaround is merged.
STM32F439xI-family AES hardware acceleration occasionally produces
incorrect output (#4928).
Don't enable AES HW acceleration on STM32F439xI-family targets by
default until issue #4928 is fixed.
Status
READY for REVIEW as WORKAROUND
This is a workaround for issue #4928